[MRG] Add docs for TfidfTransformer.idf_ (Fixes #8267) #8528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2017 13:18
Codecov Report
@@ Coverage Diff @@
## master #8528 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 342 342
Lines 60913 60913
=======================================
Hits 58160 58160
Misses 2753 2753
Continue to review full report at Codecov.
|
amueller
reviewed
Mar 4, 2017
| @@ -189,7 +189,7 @@ def build_preprocessor(self): | |||
| # hundreds of nanoseconds which is negligible when compared to the | |||
| # cost of tokenizing a string of 1000 chars for instance. | |||
| noop = lambda x: x | |||
|
|
|||
jnothman
reviewed
Mar 5, 2017
| Attributes | ||
| ---------- | ||
| idf_ : numpy array of shape [n_features, 1] | ||
| returns None unless use_idf=True, then |
There was a problem hiding this comment.
We would not usually describe an attribute with "returns".
| ---------- | ||
| idf_ : numpy array of shape [n_features, 1] | ||
| returns None unless use_idf=True, then | ||
| returns 1-D matrix containing idf(d,t). |
There was a problem hiding this comment.
I don't get what d is and why this 1-d vector is a function of two indices.
raghavrv
suggested changes
Mar 7, 2017
| @@ -996,6 +996,12 @@ class TfidfTransformer(BaseEstimator, TransformerMixin): | |||
| sublinear_tf : boolean, default=False | |||
| Apply sublinear tf scaling, i.e. replace tf with 1 + log(tf). | |||
|
|
|||
| Attributes | |||
| ---------- | |||
| idf_ : numpy array of shape [n_features, 1] | |||
|
fixed in #10899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8267
What does this implement/fix? Explain your changes.
Any other comments?