Skip to content

[MRG+1] More informative error message for classification metrics given regression output #9275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2017
Merged

[MRG+1] More informative error message for classification metrics given regression output #9275

merged 1 commit into from
Jul 10, 2017

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Jul 4, 2017 •
edited
Loading

More informative error message for classification metrics given regression output.

See #9264

@jnothman jnothman added Easy Well-defined and straightforward way to resolve Enhancement Waiting for Reviewer labels Jul 4, 2017
@SebastinSanty
Copy link
Contributor

@jnothman What exactly seems to be the problem with this patch?

@jnothman
Copy link
Member Author

jnothman commented Jul 8, 2017

No one has reviewed it

@jnothman
Copy link
Member Author

jnothman commented Jul 8, 2017

It shouldn't be labelled need contributor. Fat fingers.

@jnothman
Copy link
Member Author

jnothman commented Jul 8, 2017

Thanks for letting me know

@TomDLT TomDLT changed the title [MRG] More informative error message for classification metrics given regression output [MRG+1] More informative error message for classification metrics given regression output Jul 10, 2017
TomDLT
TomDLT approved these changes Jul 10, 2017
View reviewed changes
Copy link
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmschrei
Copy link
Member

This LGTM as well.

@jmschrei jmschrei merged commit f99fd0d into scikit-learn:master Jul 10, 2017
@raghavrv raghavrv mentioned this pull request Jul 10, 2017
Merged
@raghavrv
Copy link
Member

Master seems to fail now after this. Fix at #9317

massich pushed a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017
@jnothman
More informative error message for classification metrics given regre…
4e10e08 
…ssion output (scikit-learn#9275)
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge tag '0.19b2' into releases
ec9e5de 
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'releases' into dfsg (reremoved joblib and jquery)
4615112 
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'dfsg' into debian
236bb58 
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@jnothman @dmohns
More informative error message for classification metrics given regre…
eb1a60c 
…ssion output (scikit-learn#9275)
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@jnothman @dmohns
More informative error message for classification metrics given regre…
3a168ca 
…ssion output (scikit-learn#9275)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@jnothman @NelleV
More informative error message for classification metrics given regre…
341b929 
…ssion output (scikit-learn#9275)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@jnothman @paulha
More informative error message for classification metrics given regre…
b0703d5 
…ssion output (scikit-learn#9275)
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@jnothman @AishwaryaRK
More informative error message for classification metrics given regre…
1349b63 
…ssion output (scikit-learn#9275)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@jnothman @maskani-moh
More informative error message for classification metrics given regre…
ca8420e 
…ssion output (scikit-learn#9275)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@jnothman
More informative error message for classification metrics given regre…
c0b00e5 
…ssion output (scikit-learn#9275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve Enhancement Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jnothman @SebastinSanty @jmschrei @raghavrv @TomDLT