Skip to content

Refactor static methods #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wdevazelhes opened this issue Jan 2, 2019 · 0 comments
Open

Refactor static methods #142

wdevazelhes opened this issue Jan 2, 2019 · 0 comments
Milestone
v0.7.0

Comments

@wdevazelhes
Copy link
Member

wdevazelhes commented Jan 2, 2019 •
edited
Loading

In PR #139, some methods were modified to prevent using self.X_ (and therefore have a new argument X) (ex: RCA._check_dimension) some of them could be static methods. It could be good to explicitly make them so
@bellet bellet added this to the v0.5.0 milestone Jan 2, 2019
@wdevazelhes wdevazelhes mentioned this issue Jan 10, 2019
Closed
@wdevazelhes wdevazelhes modified the milestones: v0.5.0, v0.6.0 Feb 13, 2019
@bellet bellet modified the milestones: v0.6.0, v0.7.0 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@bellet @wdevazelhes