Skip to content

Remove random seed in fit #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wdevazelhes opened this issue Feb 15, 2019 · 0 comments · Fixed by #224
Closed

Remove random seed in fit #171

wdevazelhes opened this issue Feb 15, 2019 · 0 comments · Fixed by #224
Milestone

Comments

@wdevazelhes
Copy link
Member

For supervised metric learners, we can give a random seed in fit, that will be used for sampling random pairs/quadruplets from the X and y. I think this seed is not data-dependent, so it should be put in the init. Doing that would also make it easier to have deterministic tests (we would just set the random state of the estimator once and for all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants