-
Notifications
You must be signed in to change notification settings - Fork 228
[MRG] Documentation: introduction to metric learning #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I still need to write a few lines about use-cases. Note that I also commented out the part listing the class methods: I think it would be better to move this to the supervised and weakly supervised sections, within a proper 'API' subsection |
This should be ready to merge - feedback is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's great !
Yes I agree, the current 'Package overview' subsection is currently not organized. We could add these comment lines, plus also organize the sections a bit (like separate weakly supervised algos from supervised etc). I'll raise an issue for that |
Merged, thanks! Moving the commented-out section should be handled by gh-149. |
This PR improves the documentation by adding a proper section introducing metric learning (problem setting, mahalanobis distance, use cases and general references). A small description of the package is also added to the index page for clarity.