Skip to content

Solves #225 : adds first line to lmnn's verbose #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2019
Merged

Solves #225 : adds first line to lmnn's verbose #253

merged 4 commits into from
Oct 28, 2019

Conversation

RobinVogel
Copy link
Contributor

@RobinVogel RobinVogel commented Oct 27, 2019 •
edited by perimosocordiae
Loading

Fixes gh-225.

@RobinVogel RobinVogel changed the title Solved #225 Solves #225 Oct 27, 2019
bellet
bellet requested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@bellet bellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Apart from more explicit names, please also rename the PR with a more explicit title for clarity :-)
Otherwise LGTM

@RobinVogel RobinVogel changed the title Solves #225 Solves #225 : adds first line to lmnn's verbose Oct 28, 2019
perimosocordiae
perimosocordiae approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@perimosocordiae perimosocordiae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks for the contribution, @RobinVogel !

bellet
bellet approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@bellet bellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@bellet bellet merged commit b871028 into scikit-learn-contrib:master Oct 28, 2019
@agramfort
Copy link
Member

Glad see former students contributing to open source @RobinVogel 👍

@RobinVogel RobinVogel deleted the issue_225 branch October 28, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perimosocordiae perimosocordiae perimosocordiae approved these changes

@bellet bellet bellet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lmnn verbose first line
4 participants
@RobinVogel @agramfort @perimosocordiae @bellet