-
Notifications
You must be signed in to change notification settings - Fork 51
Request to add t-Student-Mixture-Models #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm +1 for adding a requirement for CI. (maybe at least a soft requirement.) It's not so difficult to set up as long as the test suite already exists, and we do require tests. I had subtle bugs in polylearn because of using non-initialized memory in cython which only showed up on 32-bit windows thanks to Appveyor. Would never have caught them without CI & thorough tests. |
Thanks for the quick feedback, I will add the CI with Travis now and come back to you when done. |
It's the last point on the the workflow document: Where did you get from that we don't require it? If that requirement (and I think it is a requirement) is not documented in a particular place, we need to add it. |
CI with Travis: https://travis-ci.org/luiscarlosgph/t-Student-Mixture-Models |
Where did you get from that we don't require it?
OK. I guess we are all on the page. I was maybe trying to be too
careful/polite.
|
With regards to integrating this, it's a pity that the docs are not visible online. Is there a plan to change this after integration? |
I have put the documentation available here: http://t-student-mixture-models.readthedocs.io/en/latest |
Request for project inclusion in scikit-learn-contrib
The text was updated successfully, but these errors were encountered: