Skip to content

Request to add t-Student-Mixture-Models #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks done
luiscarlosgph opened this issue Jul 26, 2017 · 8 comments
Open
6 tasks done

Request to add t-Student-Mixture-Models #18

luiscarlosgph opened this issue Jul 26, 2017 · 8 comments

Comments

@luiscarlosgph
Copy link

Request for project inclusion in scikit-learn-contrib

  • Project name: t-Student-Mixture-Models
  • Project description: package which enables one to learn t-Student Mixture Models (diagonal, spherical, tied and full covariance matrices supported), sample them, and estimate them from data
  • Authors: Luis C. Garcia-Peraza-Herrera
  • Current repository: https://github.com/luiscarlosgph/t-Student-Mixture-Models
  • Requirements:
  • scikit-learn compatible (check_estimator passed)
  • Documentation (guide, API reference, example gallery)
  • Unit tests (coverage: 79%)
  • Python3 compatible
  • PEP8 compliant
  • Continuous integration
@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Jul 26, 2017 via email

@vene
Copy link

vene commented Jul 26, 2017

I'm +1 for adding a requirement for CI. (maybe at least a soft requirement.) It's not so difficult to set up as long as the test suite already exists, and we do require tests.

I had subtle bugs in polylearn because of using non-initialized memory in cython which only showed up on 32-bit windows thanks to Appveyor. Would never have caught them without CI & thorough tests.

@luiscarlosgph
Copy link
Author

Thanks for the quick feedback, I will add the CI with Travis now and come back to you when done.

@amueller
Copy link
Member

amueller commented Jul 26, 2017

It's the last point on the the workflow document:
image

Where did you get from that we don't require it? If that requirement (and I think it is a requirement) is not documented in a particular place, we need to add it.

@luiscarlosgph
Copy link
Author

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Jul 26, 2017 via email

@GaelVaroquaux
Copy link
Member

With regards to integrating this, it's a pity that the docs are not visible online. Is there a plan to change this after integration?

@luiscarlosgph
Copy link
Author

I have put the documentation available here: http://t-student-mixture-models.readthedocs.io/en/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants