ENH: Reflect changes from numpy namespace refactor part 3 #19078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a few complaints from the linter, could you fix those @mtsokol? You can reproduce them locally with |
Linting errors came from the fact that I modified files which already had linting issues, therefore I skipped unrelated code. Sure! I fixed them. |
0d31332 to
950f4b6
Compare
950f4b6 to
4bf47d3
Compare
rgommers
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rgommers,
Here's a new PR with follow-up work related to numpy/numpy#24376. Basically, I update all items that are being removed in Part 3 of "main namespace refactor" PRs (Also, I took opportunity to update
np.doubletonp.float64in Python files, as preferred canonical name).