Merge pull request vuejs#2185 from rhyzx/boolean-attributes

yyx990803 · yyx990803 · commit b00dbca4cc40 · 2016-01-19T09:24:16.000-05:00
Boolean attributes
diff --git a/src/directives/public/bind.js b/src/directives/public/bind.js
@@ -132,9 +132,9 @@ export default {
         }
         setClass(el, value)
       } else if (xlinkRE.test(attr)) {
-        el.setAttributeNS(xlinkNS, attr, value)
+        el.setAttributeNS(xlinkNS, attr, value === true ? '' : value)
       } else {
-        el.setAttribute(attr, value)
+        el.setAttribute(attr, value === true ? '' : value)
       }
     } else {
       el.removeAttribute(attr)
diff --git a/test/unit/specs/directives/public/bind_spec.js b/test/unit/specs/directives/public/bind_spec.js
@@ -24,6 +24,8 @@ describe('v-bind', function () {
     expect(el.hasAttribute('test')).toBe(false)
     dir.update(false)
     expect(el.hasAttribute('test')).toBe(false)
+    dir.update(true)
+    expect(el.getAttribute('test')).toBe('')
     dir.update(0)
     expect(el.getAttribute('test')).toBe('0')
   })

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,9 @@ export default {`
`132`	`132`	`}`
`133`	`133`	`setClass(el, value)`
`134`	`134`	`} else if (xlinkRE.test(attr)) {`
`135`		`- el.setAttributeNS(xlinkNS, attr, value)`
	`135`	`+ el.setAttributeNS(xlinkNS, attr, value === true ? '' : value)`
`136`	`136`	`} else {`
`137`		`- el.setAttribute(attr, value)`
	`137`	`+ el.setAttribute(attr, value === true ? '' : value)`
`138`	`138`	`}`
`139`	`139`	`} else {`
`140`	`140`	`el.removeAttribute(attr)`