From b94eb3f440ef8b89be97634d2552ce77473b8d02 Mon Sep 17 00:00:00 2001 From: xadupre Date: Fri, 20 Dec 2024 13:55:38 +0100 Subject: [PATCH 1/3] Avoid recursion error in profiling --- onnx_array_api/profiling.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/onnx_array_api/profiling.py b/onnx_array_api/profiling.py index 815f950..ab2cc6b 100644 --- a/onnx_array_api/profiling.py +++ b/onnx_array_api/profiling.py @@ -73,8 +73,8 @@ def _get_root(node, stor=None): stor.append(node) if not node.called_by: return node - if len(node.called_by) == 1: - return _get_root(node.called_by[0], stor=stor) + if len(node.called_by) == 0: + return None res = None for ct in node.called_by: k = id(node), id(ct) From d51663ca6d806b4712b2b4be98ac06c063dbb74e Mon Sep 17 00:00:00 2001 From: xadupre Date: Fri, 20 Dec 2024 14:21:42 +0100 Subject: [PATCH 2/3] disable two tests --- CHANGELOGS.rst | 3 ++- _unittests/ut_npx/test_sklearn_array_api.py | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOGS.rst b/CHANGELOGS.rst index e435a75..dd8e3c7 100644 --- a/CHANGELOGS.rst +++ b/CHANGELOGS.rst @@ -4,7 +4,8 @@ Change Logs 0.3.0 +++++ -* :pr:`87`: add command line to replace contant by ConstantOfShape +* :pr:`92`: avoids recursion errors in profiling +* :pr:`87`: adds command line to replace contant by ConstantOfShape * :pr:`79`: first draft to export to GraphBuilder * :pr:`77`: supports ConcatOfShape and Slice with the light API diff --git a/_unittests/ut_npx/test_sklearn_array_api.py b/_unittests/ut_npx/test_sklearn_array_api.py index 083c009..9c0d56f 100644 --- a/_unittests/ut_npx/test_sklearn_array_api.py +++ b/_unittests/ut_npx/test_sklearn_array_api.py @@ -17,6 +17,7 @@ class TestSklearnArrayAPI(ExtTestCase): reason="reshape ArrayAPI not followed", ) @ignore_warnings(DeprecationWarning) + @unittest.skip("not maintained") def test_sklearn_array_api_linear_discriminant(self): X = np.array( [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64 @@ -39,6 +40,7 @@ def test_sklearn_array_api_linear_discriminant(self): reason="reshape ArrayAPI not followed", ) @ignore_warnings(DeprecationWarning) + @unittest.skip("not maintained") def test_sklearn_array_api_linear_discriminant_float32(self): X = np.array( [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32 From eed11892105e4ce412dd444c0cbdc9107c2fdefb Mon Sep 17 00:00:00 2001 From: xadupre Date: Fri, 20 Dec 2024 15:19:38 +0100 Subject: [PATCH 3/3] disable tests --- _unittests/ut_ort/test_sklearn_array_api_ort.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/_unittests/ut_ort/test_sklearn_array_api_ort.py b/_unittests/ut_ort/test_sklearn_array_api_ort.py index 296a9b0..f50fce1 100644 --- a/_unittests/ut_ort/test_sklearn_array_api_ort.py +++ b/_unittests/ut_ort/test_sklearn_array_api_ort.py @@ -17,6 +17,7 @@ class TestSklearnArrayAPIOrt(ExtTestCase): reason="reshape ArrayAPI not followed", ) @skipif_ci_windows("Unstable on Windows.") + @unittest.skip("discontinued") def test_sklearn_array_api_linear_discriminant_ort(self): X = np.array( [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64 @@ -40,6 +41,7 @@ def test_sklearn_array_api_linear_discriminant_ort(self): reason="reshape ArrayAPI not followed", ) @skipif_ci_windows("Unstable on Windows.") + @unittest.skip("discontinued") def test_sklearn_array_api_linear_discriminant_ort_float32(self): X = np.array( [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32