fix(): Replace href links in landing section (#98)

imklau · jedrzejchalubek · commit aa45b89c2d34 · 2019-10-07T12:09:50.000+02:00
diff --git a/src/_data/landing.yml b/src/_data/landing.yml
@@ -1,31 +1,39 @@
 - name: Guides
   icon: icon-guides.svg
   description: "Start here! Best practices, Setup steps, and other useful information."
+  path: /guides
 
 - name: Academy
   icon: icon-academy.svg
   description: "Learn more about the 'whys' and 'hows' of analytics. A great read if you're just getting started."
+  path: /academy
 
 - name: App
   icon: icon-app.svg
   description: "Learn your way around the Segment web application - hook up data sources to tools and warehouses, set up filtering, and more."
+  path: /app
 
 - name: Connections
   icon: icon-connections.svg
   description: "Collect data once, and integrate tools for analytics, growth, marketing and more."
+  path: /connections
 
 - name: Protocols
   icon: icon-protocols.svg
   description: "Prevent data quality issues before they start with a tracking schema and data quality enforcement."
+  path: /protocols
 
 - name: Personas
   icon: icon-personas.svg
   description: "Improve your interactions by building audiences to personalize experiences."
+  path: /personas
 
 - name: Privacy
   icon: icon-privacy.svg
   description: "Respect your customers’ privacy with tools for data discovery and policy enforcement."
+  path: /privacy
 
 - name: Partners
   icon: icon-partners.svg
   description: "Join the Segment Platform and enable thousands of companies to activate their first party data."
+  path: /partners
diff --git a/src/_includes/components/media-icon.html b/src/_includes/components/media-icon.html
@@ -1,5 +1,5 @@
 <div  class="media-icon media-icon--{{ include.variant }}">
-  <a class="media-icon__inner" href="{{ include.href }}">
+  <a class="media-icon__inner" href="{{ site.baseurl }}{{ include.href }}">
     <span class="media-icon__icon">
       {% include icons/media/{{ include.icon }} %}
     </span>
diff --git a/src/_includes/landing.html b/src/_includes/landing.html
@@ -1,14 +1,7 @@
 <div class="flex flex--wrap waffle waffle--large">
   {% for category in site.data.landing %}
-    {% assign url = category.name | downcase %}
-
-    {% if url contains "app" %}
-      {% assign url = url | replace: "app", "segment-app" %}
-      {% assign category_href = url | relative_path %}
-    {% endif %}
-
     <div class="flex__column flex__column--6">
-      {% include components/media-icon.html variant="small" href=category_href icon=category.icon title=category.name content=category.description %}
+      {% include components/media-icon.html variant="small" href=category.path icon=category.icon title=category.name content=category.description %}
     </div>
   {% endfor %}
 </div>
