Skip to content

Make left-nav position indicator less subtle #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanscontext opened this issue Jan 21, 2020 · 6 comments · Fixed by #664
Closed

Make left-nav position indicator less subtle #533

sanscontext opened this issue Jan 21, 2020 · 6 comments · Fixed by #664
Assignees
Labels

Comments

@sanscontext
Copy link
Contributor

What's wrong? Describe the what you're seeing

Had some feedback that the little position indicator is too subtle and a bit confusing. (I can forward the full discussion if you'd like)
image

Suggestions for a fix

Perhaps we can make the green indicator line even thicker?

@dredecki
Copy link

We need to keep the same behavior for all menu elements. I checked the initial design and think that our proposal is still valid — green font, bigger line (on the right).

image

@sanscontext
Copy link
Contributor Author

I'm also open to any other ideas! Maybe playing around with a cursor or something?
image

@dredecki
Copy link

Making the active position always green with the extra line will be enough. The online version is not perfect and consistent, fixing that will help too.

Adding any other elements is not a solution. It will only lead to a visually chaotic UI.

@sanscontext
Copy link
Contributor Author

Agree there. What's our plan for this?

@dredecki
Copy link

I'll discuss that in person with Klaudia tomorrow and get back to you with our options here.

I'm hoping to get the exact same behavior as in the screenshot above, but need to double-check that.

@dredecki
Copy link

@sanscontext I've discussed that with Klaudia and we'll adjust the navigation to the first design project. If that will not be enough for you, we can thing about other soultions.

Design spec

  1. The active link is always green.
  2. The active link always has a green line on the left.
  3. The green line is always 2px wide and align on the right side of the gray line.
  4. The green line should have at least 32px height.
  5. If you're on the second level (connections -> connections overview) the active link should also be green.
  6. If you're on the third level (connections -> sources -> sources overview) the parent active element (sources in this case) should be in #435A6F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants