Update End to End tests

f2prateek · f2prateek · commit 66ba3da6d601 · 2018-09-10T15:12:25.000-07:00
Use library-e2e-tester instead of our handrolled solution.

Updates the analytics binary to omit anonymousId and timestamp, and uses `array` instead of `[]` shorthand to work with PHP 5.3.
diff --git a/.buildscript/e2e.sh b/.buildscript/e2e.sh
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+set -ex
+
+if [ "$RUN_E2E_TESTS" != "true" ]; then
+  echo "Skipping end to end tests."
+else
+  echo "Running end to end tests..."
+  wget https://github.com/segmentio/library-e2e-tester/releases/download/0.2.1/tester_linux_amd64 -O tester
+  chmod +x tester
+  ./tester -path='./bin/analytics'
+  echo "End to end tests completed!"
+fi
diff --git a/.travis.yml b/.travis.yml
@@ -14,6 +14,7 @@ matrix:
 script:
   - if [[ ! ${TRAVIS_PHP_VERSION:0:3} < "5.5" ]]; then  composer require overtrue/phplint; composer require squizlabs/php_codesniffer; ./vendor/bin/phplint; ./vendor/bin/phpcs; fi
   - phpunit
+  - .buildscript/e2e.sh
 
 after_success:
-  - bash <(curl -s https://codecov.io/bash)
+  - bash <(curl -s https://codecov.io/bash)
diff --git a/bin/analytics b/bin/analytics
@@ -10,20 +10,23 @@ if (in_array('--help', $argv)) {
 
 date_default_timezone_set('UTC');
 
-$options = getopt('', [
+$options = getopt('', array(
   'writeKey::',
-  'type:',        // T I P G A
-  'event::',        // x
-  'userId::',      // x x x x x
-  'groupId::',     //       x
-  'previousId::',  //         x
-  'anonymousId::', // x x x x x
-  'properties::',   // x   x
-  'name::',         //     x
-  'traits::',       //   x   x
-  'context::',      // x x x x x
-  'timestamp::'     // x x x x x
-]);
+  'type:',
+
+  'userId::',
+
+  'event::',
+  'properties::',
+
+  'name::',
+
+  'traits::',
+
+  'groupId::',
+
+  'previousId::'
+));
 
 if (empty($options['writeKey'])) {
   error('writeKey flag required');
@@ -35,44 +38,31 @@ switch ($options['type']) {
   case 'track':
     Segment::track(array(
       'userId' => $options['userId'],
-      'anonymousId' => $options['anonymousId'],
       'event' => $options['event'],
-      'properties' => parse_json($options['properties']),
-      'timestamp' => parse_timestamp($options['timestamp']),
-      'context' => parse_json($options['context'])
+      'properties' => parse_json($options['properties'])
     ));
     break;
 
   case 'identify':
     Segment::identify(array(
       'userId' => $options['userId'],
-      'anonymousId' => $options['anonymousId'],
-      'traits' => parse_json($options['traits']),
-      'timestamp' => parse_timestamp($options['timestamp']),
-      'context' => parse_json($options['context'])
+      'traits' => parse_json($options['traits'])
     ));
     break;
 
   case 'page':
     Segment::page(array(
       'userId' => $options['userId'],
-      'anonymousId' => $options['anonymousId'],
       'name' => $options['name'],
-      'category' => $options['category'],
-      'properties' => parse_json($options['properties']),
-      'timestamp' => parse_timestamp($options['timestamp']),
-      'context' => parse_json($options['context'])
+      'properties' => parse_json($options['properties'])
     ));
     break;
 
   case 'group':
     Segment::identify(array(
       'userId' => $options['userId'],
-      'anonymousId' => $options['anonymousId'],
       'groupId' => $options['groupId'],
-      'traits' => parse_json($options['traits']),
-      'timestamp' => parse_timestamp($options['timestamp']),
-      'context' => parse_json($options['context'])
+      'traits' => parse_json($options['traits'])
     ));
     break;
 
diff --git a/test/AnalyticsE2ETest.php b/test/AnalyticsE2ETest.php
