quantcast: cleanup

ianstormtaylor · ianstormtaylor · commit c6e12d08b89c · 2013-09-10T14:51:32.000-07:00
diff --git a/lib/providers/quantcast.js b/lib/providers/quantcast.js
@@ -1,26 +1,46 @@
-// https://www.quantcast.com/learning-center/guides/using-the-quantcast-asynchronous-tag/
 
-var Provider = require('../provider')
-  , load     = require('load-script');
+var integration = require('../integration')
+  , load = require('load-script');
 
 
-module.exports = Provider.extend({
+/**
+ * Expose `Quantcast` integration.
+ */
 
-  name : 'Quantcast',
+var Quantcast = module.exports = integration('Quantcast');
 
-  key : 'pCode',
 
-  defaults : {
-    pCode : null
-  },
+/**
+ * Required key.
+ */
 
-  initialize : function (options, ready) {
-    window._qevents = window._qevents || [];
-    window._qevents.push({ qacct: options.pCode });
-    load({
-      http  : 'http://edge.quantserve.com/quant.js',
-      https : 'https://secure.quantserve.com/quant.js'
-    }, ready);
-  }
+Quantcast.prototype.key = 'pCode';
 
-});
+
+/**
+ * Default options.
+ */
+
+Quantcast.prototype.defaults = {
+  // your quantcast p code (required)
+  pCode: null
+};
+
+
+/**
+ * Initialize.
+ *
+ * https://www.quantcast.com/learning-center/guides/using-the-quantcast-asynchronous-tag/
+ *
+ * @param {Object} options
+ * @param {Function} ready
+ */
+
+Quantcast.prototype.initialize = function (options, ready) {
+  window._qevents || (window._qevents = []);
+  window._qevents.push({ qacct: options.pCode });
+  load({
+    http: 'http://edge.quantserve.com/quant.js',
+    https: 'https://secure.quantserve.com/quant.js'
+  }, ready);
+};
diff --git a/test/providers/quantcast.js b/test/providers/quantcast.js
@@ -1,40 +1,45 @@
-describe('Quantcast', function () {
-
-  var analytics = require('analytics');
-
-
-  describe('initialize', function () {
-
-    this.timeout(10000);
-
-    it('should call ready and load library', function (done) {
-      var spy  = sinon.spy()
-        , push = Array.prototype.push;
 
-      expect(window._qevents).to.be(undefined);
-
-      analytics.ready(spy);
-      analytics.initialize({ 'Quantcast' : test['Quantcast'] });
+describe('Quantcast', function () {
 
-      expect(window._qevents).not.to.be(undefined);
-      expect(window._qevents.push).to.equal(push);
+var analytics = window.analytics || require('analytics')
+  , assert = require('assert')
+  , sinon = require('sinon')
+  , when = require('when');
+
+var settings = {
+  pCode: 'x'
+};
+
+before(function (done) {
+  this.timeout(10000);
+  this.spy = sinon.spy();
+  analytics.ready(this.spy);
+  analytics.initialize({ Quantcast: settings });
+  this.integration = analytics._integrations.Quantcast;
+  this.options = this.integration.options;
+  when(function () { return window.__qc; }, done);
+});
+
+describe('#key', function () {
+  it('pCode', function () {
+    assert(this.integration.key == 'pCode');
+  });
+});
 
-      // When the library loads, it will overwrite the push method.
-      var interval = setInterval(function () {
-        if (window._qevents.push === push) return;
-        expect(window._qevents.push).not.to.equal(push);
-        expect(window.__qc).not.to.be(undefined);
-        expect(spy.called).to.be(true);
-        clearInterval(interval);
-        done();
-      }, 20);
-    });
+describe('#defaults', function () {
+  it('pCode', function () {
+    assert(this.integration.defaults.pCode === null);
+  });
+});
 
-    it('should store options', function () {
-      analytics.initialize({ 'Quantcast' : test['Quantcast'] });
-      expect(analytics._providers[0].options.pCode).to.equal(test['Quantcast']);
-    });
+describe('#initialize', function () {
+  it('should call ready', function () {
+    assert(this.spy.called);
+  });
 
+  it('should store options', function () {
+    assert(this.options.pCode == settings.pCode);
   });
+});
 
 });
