Skip to content

asset options creates a untagged release that is not updated after asset upload #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kickapoo opened this issue Apr 30, 2021 · 2 comments
Open

asset options creates a untagged release that is not updated after asset upload #362

kickapoo opened this issue Apr 30, 2021 · 2 comments

Comments

@kickapoo
Copy link

kickapoo commented Apr 30, 2021 •
edited by hearts bot
Loading

Without any reasonable change that I could identify from yesterday to today all our builds where failing due "Publishing untagged version"

Screenshot 2021-04-30 at 18 47 03

In the above example, should had "v1.4.1"

After trying to debug a single line changes made the trick
Screenshot 2021-04-30 at 18 51 44

but many failing test after this change (due urgent reasons of our build system had to fork etc)

Is there something I am missing ? (will create PR etc since I dont like forks ;) )
@gr2m
Copy link
Member

gr2m commented Apr 30, 2021 •
edited by hearts bot
Loading

I saw this happening yesterday, too, for the first time, in https://github.com/octokit/openapi/releases/. I didn't change anything, so I'm not sure how the problem could have been introduced. I'd appreciate if you could start the PR, we can discuss details there?

What surprises me is that there was no update to @semantic-release/github in 25 days, but there were plenty of releases in the same timeframe: https://github.com/octokit/openapi/releases

@kickapoo kickapoo mentioned this issue May 1, 2021
Closed
@babblebey
Copy link
Member

babblebey commented Jul 31, 2024 •
edited by hearts bot
Loading

Following some bit of investigation here, it appears as though this isn't exactly an issue at all.

Screenshot 2021-04-30 at 18 47 03

In the above example, should had "v1.4.1"

The URL structure in the above quote screenshot makes the release look untagged, yes.... but this is the structure for a DRAFT Release, which I assume this release to be (unless I've thought wrongly).... I guess a draft release is not exactly tagged yet until it is really published... It is instead associated to a tag via tag_name but not yet tagged.

See below Draft Release, It was created via the GitHub UI, and it has exactly same url structure that reads untagged

https://github.com/babblebey/sr-github/releases/tag/untagged-d47c0e9fcfb9169bfebc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gr2m @kickapoo @babblebey