Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

Fix deprecation notice in test (ProcessBuilder) #564

Closed
wants to merge 3 commits into from
Closed

Fix deprecation notice in test (ProcessBuilder) #564

wants to merge 3 commits into from

Conversation

guilliamxavier
Copy link
Contributor

@guilliamxavier guilliamxavier commented Jul 16, 2017 •
edited
Loading

Backward- and forward-compatible fix for

Remaining deprecation notices (1)

The Symfony\Component\Process\ProcessBuilder class is deprecated since version 3.4 and will be removed in 4.0. Use the Process class instead: 1x
    1x in KernelManipulatorTest::testAddToArray from Sensio\Bundle\GeneratorBundle\Tests\Manipulator

Relevant commits:

I also considered the simpler test \Symfony\Component\HttpKernel\Kernel::VERSION_ID >= 30400 but it seems less reliable (version constant vs code, possibly different versions of symfony/http-kernel vs symfony/process).

@guilliamxavier
Copy link
Contributor Author

The Travis hhvm build is failing because of an unrelated reason:
HHVM is no longer supported on Ubuntu Precise. Please consider using Trusty with `dist: trusty`.

I guess this could be fixed by adding a
dist: trusty
line at the top of the .travis.yml file (or dropping HHVM support).

@fabpot
Copy link
Member

fabpot commented Jul 17, 2017

For HHVM, I think we bumped version to trusty on some other bundles, so that's probably the way to go.

@fabpot
Copy link
Member

fabpot commented Jul 17, 2017

Thank you @guilliamxavier.

@fabpot fabpot closed this in 3ac2135 Jul 17, 2017
@guilliamxavier guilliamxavier deleted the patch-4 branch July 18, 2017 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilliamxavier @fabpot