From f60eed1225f091c090f9c253771a12b33fafcab0 Mon Sep 17 00:00:00 2001 From: Piotr Grzesik Date: Thu, 2 Dec 2021 20:57:51 +0100 Subject: [PATCH 1/2] fix: Ensure cast `toString` before `trim` on buffer --- lib/docker.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/docker.js b/lib/docker.js index 5157803f..a3079ff7 100644 --- a/lib/docker.js +++ b/lib/docker.js @@ -103,12 +103,12 @@ async function tryBindPath(bindPath, testFile, pluginInstance) { const ps = await dockerCommand(options, pluginInstance); if (debug) { if (log) { - log.debug(ps.stdoutBuffer.trim()); + log.debug(ps.stdoutBuffer.toString().trim()); } else { - serverless.cli.log(ps.stdoutBuffer.trim()); + serverless.cli.log(ps.stdoutBuffer.toString().trim()); } } - return ps.stdoutBuffer.trim() === `/test/${testFile}`; + return ps.stdoutBuffer.toString().trim() === `/test/${testFile}`; } catch (err) { if (debug) { if (log) { @@ -197,7 +197,7 @@ async function getDockerUid(bindPath, pluginInstance) { '/bin/sh', ]; const ps = await dockerCommand(options, pluginInstance); - return ps.stdoutBuffer.trim(); + return ps.stdoutBuffer.toString().trim(); } module.exports = { buildImage, getBindPath, getDockerUid }; From c4808770713f451dcaa907fb40fcd34414bf7de7 Mon Sep 17 00:00:00 2001 From: Piotr Grzesik Date: Fri, 3 Dec 2021 13:49:37 +0100 Subject: [PATCH 2/2] chore: Release v5.2.2 --- CHANGELOG.md | 6 ++++++ package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bd87ce72..47570012 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [5.2.2](https://github.com/UnitedIncome/serverless-python-requirements/compare/v5.2.1...v5.2.2) (2021-12-03) + +### Bug Fixes + +- Ensure cast `toString` before `trim` on buffer ([#656](https://github.com/serverless/serverless-python-requirements/pull/656)) ([f60eed1](https://github.com/UnitedIncome/serverless-python-requirements/commit/f60eed1225f091c090f9c253771a12b33fafcab0)) ([Piotr Grzesik](https://github.com/pgrzesik)) + ### [5.2.1](https://github.com/UnitedIncome/serverless-python-requirements/compare/v5.2.0...v5.2.1) (2021-11-30) ### Maintenance Improvements diff --git a/package.json b/package.json index c6a1f5e6..44554659 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "serverless-python-requirements", - "version": "5.2.1", + "version": "5.2.2", "engines": { "node": ">=12.0" },