From eaa61d02323f65590f5e734feb94fa222efaad36 Mon Sep 17 00:00:00 2001 From: jlegreid Date: Mon, 4 Apr 2022 15:26:23 +0100 Subject: [PATCH 1/2] fix: Change defaultNextLambda removalPolicy from DESTROY to RETAIN --- .../serverless-components/nextjs-cdk-construct/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/serverless-components/nextjs-cdk-construct/src/index.ts b/packages/serverless-components/nextjs-cdk-construct/src/index.ts index 5c901adf72..351ecda50e 100644 --- a/packages/serverless-components/nextjs-cdk-construct/src/index.ts +++ b/packages/serverless-components/nextjs-cdk-construct/src/index.ts @@ -153,7 +153,7 @@ export class NextJSLambdaEdge extends Construct { description: `Default Lambda@Edge for Next CloudFront distribution`, handler: "index.handler", currentVersionOptions: { - removalPolicy: RemovalPolicy.DESTROY // destroy old versions + removalPolicy: RemovalPolicy.RETAIN // retain old versions to prevent premature removal, cleanup via trigger later on }, logRetention: logs.RetentionDays.THREE_DAYS, code: lambda.Code.fromAsset( From 9922c1e196715e741573135eaa55a4aadfe3915f Mon Sep 17 00:00:00 2001 From: jlegreid Date: Mon, 4 Apr 2022 16:18:36 +0100 Subject: [PATCH 2/2] test: updates snapshot test to reflect policy change --- .../__tests__/__snapshots__/snapshots.test.ts.snap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/serverless-components/nextjs-cdk-construct/__tests__/__snapshots__/snapshots.test.ts.snap b/packages/serverless-components/nextjs-cdk-construct/__tests__/__snapshots__/snapshots.test.ts.snap index d50e1a1a31..c58269170c 100644 --- a/packages/serverless-components/nextjs-cdk-construct/__tests__/__snapshots__/snapshots.test.ts.snap +++ b/packages/serverless-components/nextjs-cdk-construct/__tests__/__snapshots__/snapshots.test.ts.snap @@ -1250,14 +1250,14 @@ Object { "Type": "AWS::CloudFront::CachePolicy", }, "StackNextLambdaCurrentVersion21F01F879970bafa5c9141f6152d4057c3ab8184": Object { - "DeletionPolicy": "Delete", + "DeletionPolicy": "Retain", "Properties": Object { "FunctionName": Object { "Ref": "StackNextLambdaF64DCE99", }, }, "Type": "AWS::Lambda::Version", - "UpdateReplacePolicy": "Delete", + "UpdateReplacePolicy": "Retain", }, "StackNextLambdaCurrentVersionAliasliveB07D2AA0": Object { "Properties": Object { @@ -2999,14 +2999,14 @@ Object { "Type": "AWS::CloudFront::CachePolicy", }, "StackNextLambdaCurrentVersion21F01F87b5875487743b0e6b4f7058e417862406": Object { - "DeletionPolicy": "Delete", + "DeletionPolicy": "Retain", "Properties": Object { "FunctionName": Object { "Ref": "StackNextLambdaF64DCE99", }, }, "Type": "AWS::Lambda::Version", - "UpdateReplacePolicy": "Delete", + "UpdateReplacePolicy": "Retain", }, "StackNextLambdaCurrentVersionAliasliveB07D2AA0": Object { "Properties": Object {