From 97e1c99e29459dccccde6ba3161277ee44173d88 Mon Sep 17 00:00:00 2001 From: Charles d'Avernas Date: Tue, 25 Mar 2025 10:04:18 +0100 Subject: [PATCH 1/2] Move config.yml to .github/ISSUE_TEMPLATE Signed-off-by: Charles d'Avernas --- config.yml => .github/ISSUE_TEMPLATE/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename config.yml => .github/ISSUE_TEMPLATE/config.yml (60%) diff --git a/config.yml b/.github/ISSUE_TEMPLATE/config.yml similarity index 60% rename from config.yml rename to .github/ISSUE_TEMPLATE/config.yml index 8e9f9162..8005e322 100644 --- a/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,2 +1,2 @@ blank_issues_enabled: false -contact_links: [] \ No newline at end of file +contact_links: [] From bb708dead8cf9ee60c5304ecf297e6cf8c665b77 Mon Sep 17 00:00:00 2001 From: Charles d'Avernas Date: Wed, 16 Apr 2025 14:25:11 +0200 Subject: [PATCH 2/2] fix(Runner): Fixed the `WorkflowProcessExecutor`, which was attempting to create a subflow using the runner's namespace, instead of the configured one when creating a new subflow instance Signed-off-by: Charles d'Avernas --- .../Services/Executors/WorkflowProcessExecutor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runner/Synapse.Runner/Services/Executors/WorkflowProcessExecutor.cs b/src/runner/Synapse.Runner/Services/Executors/WorkflowProcessExecutor.cs index 95486488..5d72d53b 100644 --- a/src/runner/Synapse.Runner/Services/Executors/WorkflowProcessExecutor.cs +++ b/src/runner/Synapse.Runner/Services/Executors/WorkflowProcessExecutor.cs @@ -60,7 +60,7 @@ protected override async Task DoExecuteAsync(CancellationToken cancellationToken { var hash = Convert.ToHexString(MD5.HashData(Encoding.UTF8.GetBytes($"{Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runner.Name)}{this.Task.Instance.Reference}"))).ToLowerInvariant(); var workflowInstanceName = $"{this.ProcessDefinition.Name}-{hash}"; - var workflowInstanceNamespace = Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runner.Namespace)!; + var workflowInstanceNamespace = this.ProcessDefinition.Namespace; try { this.Subflow = await this.Api.WorkflowInstances.GetAsync(workflowInstanceName, workflowInstanceNamespace, cancellationToken).ConfigureAwait(false);