Skip to content

Commit ad68b50

Browse files
committed
chore: merge master into frame-and-router
2 parents 07f976b + db6df39 commit ad68b50

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed

index.d.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ declare module 'nativescript-vue' {
1111
* @param resolver function to register the element
1212
* @param meta meta associated with the element
1313
*/
14-
static registerElement(elementName: string, resolver: Function, meta?: any);
14+
static registerElement(elementName: string, resolver: Function, meta?: any): void;
15+
16+
/**
17+
* starts the nativescript application
18+
*/
19+
$run(): void
1520
}
1621

1722
export = NativeScriptVue;

platform/nativescript/util/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function isUnknownElement(el) {
3131
}
3232

3333
export function isPage(el) {
34-
return el && el.tagName === 'page'
34+
return el && el.tagName === 'nativepage'
3535
}
3636

3737
/** @deprecated */

samples/app/app-with-pages.js

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@ Vue.config.silent = false
55

66
const App = {
77
template: `
8-
<Frame ref="frame">
9-
<Page>
10-
<StackLayout>
11-
<Button text="Open page" @tap="openPage" />
12-
</StackLayout>
13-
</Page>
14-
</Frame>
8+
<Frame>
9+
<Page>
10+
<ActionBar class="action-bar" title="Home Page">
11+
<ActionItem text="Action"></ActionItem>
12+
</ActionBar>
13+
<StackLayout>
14+
<Button text="Open page" @tap="openPage" />
15+
</StackLayout>
16+
</Page>
17+
</Frame>
1518
`,
1619

1720
methods: {
@@ -23,13 +26,16 @@ const App = {
2326

2427
const DetailsPage = {
2528
template: `
26-
<Page>
27-
<StackLayout>
28-
<Label :text="'Details ' + Math.random()" />
29-
<Button text="another" @tap="openDetails" />
30-
<Button text="back" @tap="goBack" />
31-
</StackLayout>
32-
</Page>
29+
<Page>
30+
<ActionBar class="action-bar" title="Details Page">
31+
<ActionItem text="Action"></ActionItem>
32+
</ActionBar>
33+
<StackLayout>
34+
<Label :text="'Details ' + Math.random()" />
35+
<Button text="another" @tap="openDetails" />
36+
<Button text="back" @tap="goBack" />
37+
</StackLayout>
38+
</Page>
3339
`,
3440

3541
methods: {

0 commit comments

Comments
 (0)