Skip to content

Commit 9a26ca1

Browse files
committed
chore: fixes
1 parent 79244b5 commit 9a26ca1

File tree

9 files changed

+19
-9
lines changed

9 files changed

+19
-9
lines changed

e2e/tests-app-ng/app/app.routes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const routableComponents = [
9696

9797
// Set `isNavigatable: true` if the page is a main page to other sub pages
9898
export const routes = [
99-
{ path: "", pathMatch: "full", redirectTo: "binding" },
99+
{ path: "", pathMatch: "full", redirectTo: "main" },
100100
{ path: "main", component: MainComponent, data: { title: "" } },
101101
// { path: "", component: ModalContentComponent, data: { title: "" } },
102102
{ path: "template", component: AppComponent, data: { title: "Template", isNavigatable: true } },

e2e/tests-app-ng/app/button/button-main-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component } from "@angular/core";
22

33
@Component({
4-
selector: "main",
4+
selector: "main-button",
55
template: `
66
<StackLayout>
77
<Button text="text-alignment" [nsRouterLink]="['button-text-alignment']"></Button>

e2e/tests-app-ng/app/list-picker/list-picker-main-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component } from "@angular/core";
22

33
@Component({
4-
selector: "main",
4+
selector: "main-list-picker",
55
template: `
66
<StackLayout>
77
<Button text="ListPicker" [nsRouterLink]="['/listPicker','list-picker']"></Button>

e2e/tests-app-ng/app/list-view/list-view-main-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component } from "@angular/core";
22

33
@Component({
4-
selector: "main",
4+
selector: "main-listview",
55
template: `
66
<StackLayout>
77
<Button text="ListView" [nsRouterLink]="'commonTemplate'"></Button>

e2e/tests-app-ng/app/list-view/list-view-nested-template.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component, ChangeDetectionStrategy } from "@angular/core";
22

33
@Component({
4-
selector: "list-test",
4+
selector: "list-test-nested",
55
template: `
66
<GridLayout rows="* auto" automationText="mainView" iosOverflowSafeArea="false" >
77
<ListView [items]="myItems">

e2e/tests-app-ng/app/main.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import { platformNativeScriptDynamic } from "@nativescript/angular/platform";
22

33
import { AppModule } from "./app.module";
4+
import { enable } from "@nativescript/core/trace";
5+
6+
enable();
47

58
platformNativeScriptDynamic().bootstrapModule(AppModule);

e2e/tests-app-ng/app/main/main-page-router-outlet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Component } from "@angular/core";
22
import * as platform from "@nativescript/core/platform";
33

44
@Component({
5-
selector: "main",
5+
selector: "main-page",
66
styles: [
77
".main-btn{" +
88
"margin-right:5; margin-bottom:5;" +

e2e/tests-app-ng/app/modal/modal-view-main-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Component } from "@angular/core";
22

33
@Component({
4-
selector: "main",
4+
selector: "main-modal",
55
template: `
66
<StackLayout>
77
<Button text="modal" [nsRouterLink]="['/modal','modal-dialogs']"></Button>

nativescript-angular/platform-common.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,9 @@ export class NativeScriptPlatformRef extends PlatformRef {
218218
// Custom launch view color (useful when doing async app intializers where you don't want a flash of undesirable color)
219219
launchView.backgroundColor = new Color(this.appOptions && this.appOptions.backgroundColor ? this.appOptions.backgroundColor : '#fff');
220220
}
221-
args.root = launchView;
221+
222222
setRootPage(<any>launchView);
223+
args.root = launchView;
223224

224225
// Launch Angular app on next tick
225226
setTimeout(() => {
@@ -255,7 +256,13 @@ export class NativeScriptPlatformRef extends PlatformRef {
255256
rootContent = this.createErrorUI(errorMessage);
256257
}
257258
);
258-
// (<any>global).Zone.drainMicroTaskQueue();
259+
if (isLogEnabled()) {
260+
bootstrapLog("bootstrapAction called, draining micro tasks queue. Root: " + rootContent);
261+
}
262+
(<any>global).Zone.drainMicroTaskQueue();
263+
if (isLogEnabled()) {
264+
bootstrapLog("bootstrapAction called, draining micro tasks queue finished! Root: " + rootContent);
265+
}
259266
});
260267
}
261268
);

0 commit comments

Comments
 (0)