Log deprecation warning for timeout argument in Producer.stop()

Dana Powers · Dana Powers · commit 31ee4ed2af6d · 2015-12-06T12:18:22.000-08:00
diff --git a/kafka/producer/base.py b/kafka/producer/base.py
@@ -415,16 +415,20 @@ def _send_messages(self, topic, partition, *msg, **kwargs):
                 raise
         return resp
 
-    def stop(self):
+    def stop(self, timeout=None):
         """
         Stop the producer (async mode). Blocks until async thread completes.
         """
+        if timeout is not None:
+            log.warning('timeout argument to stop() is deprecated - '
+                        'it will be removed in future release')
+
         if not self.async:
-            log.warning("producer.stop() called, but producer is not async")
+            log.warning('producer.stop() called, but producer is not async')
             return
 
         if self.stopped:
-            log.warning("producer.stop() called, but producer is already stopped")
+            log.warning('producer.stop() called, but producer is already stopped')
             return
 
         if self.async:
