win: Delete temp file on reboot, fix electron#1084

zcbenz · zcbenz · commit 11cb777e35d7 · 2015-02-02T17:03:52.000-08:00
diff --git a/atom/common/asar/scoped_temporary_file.cc b/atom/common/asar/scoped_temporary_file.cc
@@ -16,12 +16,13 @@ ScopedTemporaryFile::ScopedTemporaryFile() {
 
 ScopedTemporaryFile::~ScopedTemporaryFile() {
   if (!path_.empty()) {
-    // On Windows calling base::DeleteFile on exit will call an API that would
-    // halt the program, so we have to call the win32 API directly.
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    // On Windows it is very likely the file is already in use (because it is
+    // mostly used for Node native modules), so deleting it now will halt the
+    // program.
 #if defined(OS_WIN)
-    ::DeleteFile(path_.value().c_str());
+    base::DeleteFileAfterReboot(path_);
 #else
-    base::ThreadRestrictions::ScopedAllowIO allow_io;
     base::DeleteFile(path_, false);
 #endif
   }
