mac: Use AsNSImage instead of ToNSImage

zcbenz · zcbenz · commit 443a4b8f2f37 · 2015-02-12T12:29:49.000+08:00
It can get rid of the empty check.
diff --git a/atom/browser/ui/tray_icon_cocoa.mm b/atom/browser/ui/tray_icon_cocoa.mm
@@ -54,13 +54,11 @@ - (void)handleDoubleClick:(id)sender {
 }
 
 void TrayIconCocoa::SetImage(const gfx::Image& image) {
-  if (!image.IsEmpty())
-    [item_ setImage:image.ToNSImage()];
+  [item_ setImage:image.AsNSImage()];
 }
 
 void TrayIconCocoa::SetPressedImage(const gfx::Image& image) {
-  if (!image.IsEmpty())
-    [item_ setAlternateImage:image.ToNSImage()];
+  [item_ setAlternateImage:image.AsNSImage()];
 }
 
 void TrayIconCocoa::SetToolTip(const std::string& tool_tip) {

Original file line number	Diff line number	Diff line change
`@@ -54,13 +54,11 @@ - (void)handleDoubleClick:(id)sender {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`void TrayIconCocoa::SetImage(const gfx::Image& image) {`
`57`		`- if (!image.IsEmpty())`
`58`		`- [item_ setImage:image.ToNSImage()];`
	`57`	`+ [item_ setImage:image.AsNSImage()];`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`void TrayIconCocoa::SetPressedImage(const gfx::Image& image) {`
`62`		`- if (!image.IsEmpty())`
`63`		`- [item_ setAlternateImage:image.ToNSImage()];`
	`61`	`+ [item_ setAlternateImage:image.AsNSImage()];`
`64`	`62`	`}`
`65`	`63`
`66`	`64`	`void TrayIconCocoa::SetToolTip(const std::string& tool_tip) {`