Skip to content

Commit ade45c2

Browse files
youknowoneyouknowone
authored
Merge pull request RustPython#5391 from JazzGlobal/4982-AddMissingFieldsToPyStructTime
2 parents b067986 + 763ba9f commit ade45c2

File tree

4 files changed

+64
-40
lines changed

4 files changed

+64
-40
lines changed

‎Lib/test/test_time.py

+9-6
Original file line numberDiff line numberDiff line change
@@ -718,9 +718,10 @@ class TestAsctime4dyear(_TestAsctimeYear, _Test4dYear, unittest.TestCase):
718718

719719

720720
class TestPytime(unittest.TestCase):
721+
# TODO: RUSTPYTHON
722+
@unittest.expectedFailure
721723
@skip_if_buggy_ucrt_strfptime
722-
@unittest.skip("TODO: RUSTPYTHON, AttributeError: module 'time' has no attribute '_STRUCT_TM_ITEMS'")
723-
# @unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
724+
@unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
724725
def test_localtime_timezone(self):
725726

726727
# Get the localtime and examine it for the offset and zone.
@@ -755,16 +756,18 @@ def test_localtime_timezone(self):
755756
self.assertEqual(new_lt.tm_gmtoff, lt.tm_gmtoff)
756757
self.assertEqual(new_lt9.tm_zone, lt.tm_zone)
757758

758-
@unittest.skip("TODO: RUSTPYTHON, AttributeError: module 'time' has no attribute '_STRUCT_TM_ITEMS'")
759-
# @unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
759+
# TODO: RUSTPYTHON
760+
@unittest.expectedFailure
761+
@unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
760762
def test_strptime_timezone(self):
761763
t = time.strptime("UTC", "%Z")
762764
self.assertEqual(t.tm_zone, 'UTC')
763765
t = time.strptime("+0500", "%z")
764766
self.assertEqual(t.tm_gmtoff, 5 * 3600)
765767

766-
@unittest.skip("TODO: RUSTPYTHON, AttributeError: module 'time' has no attribute '_STRUCT_TM_ITEMS'")
767-
# @unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
768+
# TODO: RUSTPYTHON
769+
@unittest.expectedFailure
770+
@unittest.skipUnless(time._STRUCT_TM_ITEMS == 11, "needs tm_zone support")
768771
def test_short_times(self):
769772

770773
import pickle

‎derive-impl/src/pystructseq.rs

+15-15
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,19 @@ fn field_names(input: &mut DeriveInput) -> Result<(Vec<Ident>, Vec<Ident>)> {
8080
}
8181

8282
pub(crate) fn impl_pystruct_sequence(mut input: DeriveInput) -> Result<TokenStream> {
83-
let (not_skipped_fields, _skipped_fields) = field_names(&mut input)?;
83+
let (not_skipped_fields, skipped_fields) = field_names(&mut input)?;
8484
let ty = &input.ident;
8585
let ret = quote! {
8686
impl ::rustpython_vm::types::PyStructSequence for #ty {
87-
const FIELD_NAMES: &'static [&'static str] = &[#(stringify!(#not_skipped_fields)),*];
87+
const REQUIRED_FIELD_NAMES: &'static [&'static str] = &[#(stringify!(#not_skipped_fields),)*];
88+
const OPTIONAL_FIELD_NAMES: &'static [&'static str] = &[#(stringify!(#skipped_fields),)*];
8889
fn into_tuple(self, vm: &::rustpython_vm::VirtualMachine) -> ::rustpython_vm::builtins::PyTuple {
89-
let items = vec![#(::rustpython_vm::convert::ToPyObject::to_pyobject(
90-
self.#not_skipped_fields,
91-
vm,
92-
)),*];
90+
let items = vec![
91+
#(::rustpython_vm::convert::ToPyObject::to_pyobject(
92+
self.#not_skipped_fields,
93+
vm,
94+
),)*
95+
];
9396
::rustpython_vm::builtins::PyTuple::new_unchecked(items.into_boxed_slice())
9497
}
9598
}
@@ -110,17 +113,14 @@ pub(crate) fn impl_pystruct_sequence_try_from_object(
110113
let ret = quote! {
111114
impl ::rustpython_vm::TryFromObject for #ty {
112115
fn try_from_object(vm: &::rustpython_vm::VirtualMachine, seq: ::rustpython_vm::PyObjectRef) -> ::rustpython_vm::PyResult<Self> {
113-
const LEN: usize = #ty::FIELD_NAMES.len();
114-
let seq = Self::try_elements_from::<LEN>(seq, vm)?;
115-
// TODO: this is possible to be written without iterator
116+
let seq = Self::try_elements_from(seq, vm)?;
116117
let mut iter = seq.into_iter();
117118
Ok(Self {
118-
#(
119-
#not_skipped_fields: iter.next().unwrap().clone().try_into_value(vm)?,
120-
)*
121-
#(
122-
#skipped_fields: vm.ctx.none(),
123-
)*
119+
#(#not_skipped_fields: iter.next().unwrap().clone().try_into_value(vm)?,)*
120+
#(#skipped_fields: match iter.next() {
121+
Some(v) => v.clone().try_into_value(vm)?,
122+
None => vm.ctx.none(),
123+
},)*
124124
})
125125
}
126126
}

‎vm/src/stdlib/time.rs

+15-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ mod decl {
3939
types::PyStructSequence,
4040
};
4141
use chrono::{
42-
DateTime, Datelike, Timelike,
42+
DateTime, Datelike, TimeZone, Timelike,
4343
naive::{NaiveDate, NaiveDateTime, NaiveTime},
4444
};
4545
use std::time::Duration;
@@ -72,6 +72,9 @@ mod decl {
7272
.map_err(|e| vm.new_value_error(format!("Time error: {e:?}")))
7373
}
7474

75+
#[pyattr]
76+
pub const _STRUCT_TM_ITEMS: usize = 11;
77+
7578
// TODO: implement proper monotonic time for wasm/wasi.
7679
#[cfg(not(any(unix, windows)))]
7780
fn get_monotonic_time(vm: &VirtualMachine) -> PyResult<Duration> {
@@ -451,6 +454,10 @@ mod decl {
451454
tm_wday: PyObjectRef,
452455
tm_yday: PyObjectRef,
453456
tm_isdst: PyObjectRef,
457+
#[pystruct(skip)]
458+
tm_gmtoff: PyObjectRef,
459+
#[pystruct(skip)]
460+
tm_zone: PyObjectRef,
454461
}
455462

456463
impl std::fmt::Debug for PyStructTime {
@@ -462,6 +469,11 @@ mod decl {
462469
#[pyclass(with(PyStructSequence))]
463470
impl PyStructTime {
464471
fn new(vm: &VirtualMachine, tm: NaiveDateTime, isdst: i32) -> Self {
472+
let local_time = chrono::Local.from_local_datetime(&tm).unwrap();
473+
let offset_seconds =
474+
local_time.offset().local_minus_utc() + if isdst == 1 { 3600 } else { 0 };
475+
let tz_abbr = local_time.format("%Z").to_string();
476+
465477
PyStructTime {
466478
tm_year: vm.ctx.new_int(tm.year()).into(),
467479
tm_mon: vm.ctx.new_int(tm.month()).into(),
@@ -472,6 +484,8 @@ mod decl {
472484
tm_wday: vm.ctx.new_int(tm.weekday().num_days_from_monday()).into(),
473485
tm_yday: vm.ctx.new_int(tm.ordinal()).into(),
474486
tm_isdst: vm.ctx.new_int(isdst).into(),
487+
tm_gmtoff: vm.ctx.new_int(offset_seconds).into(),
488+
tm_zone: vm.ctx.new_str(tz_abbr).into(),
475489
}
476490
}
477491

‎vm/src/types/structseq.rs

+25-18
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
use crate::{
22
AsObject, Py, PyObjectRef, PyPayload, PyRef, PyResult, VirtualMachine,
3-
builtins::{PyTuple, PyTupleRef, PyType},
3+
builtins::{PyBaseExceptionRef, PyTuple, PyTupleRef, PyType},
44
class::{PyClassImpl, StaticType},
55
vm::Context,
66
};
77

88
#[pyclass]
99
pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
10-
const FIELD_NAMES: &'static [&'static str];
10+
const REQUIRED_FIELD_NAMES: &'static [&'static str];
11+
const OPTIONAL_FIELD_NAMES: &'static [&'static str];
1112

1213
fn into_tuple(self, vm: &VirtualMachine) -> PyTuple;
1314

@@ -17,10 +18,16 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
1718
.unwrap()
1819
}
1920

20-
fn try_elements_from<const FIELD_LEN: usize>(
21-
obj: PyObjectRef,
22-
vm: &VirtualMachine,
23-
) -> PyResult<[PyObjectRef; FIELD_LEN]> {
21+
fn try_elements_from(obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<Vec<PyObjectRef>> {
22+
#[cold]
23+
fn sequence_length_error(
24+
name: &str,
25+
len: usize,
26+
vm: &VirtualMachine,
27+
) -> PyBaseExceptionRef {
28+
vm.new_type_error(format!("{name} takes a sequence of length {len}"))
29+
}
30+
2431
let typ = Self::static_type();
2532
// if !obj.fast_isinstance(typ) {
2633
// return Err(vm.new_type_error(format!(
@@ -30,13 +37,13 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
3037
// )));
3138
// }
3239
let seq: Vec<PyObjectRef> = obj.try_into_value(vm)?;
33-
let seq: [PyObjectRef; FIELD_LEN] = seq.try_into().map_err(|_| {
34-
vm.new_type_error(format!(
35-
"{} takes a sequence of length {}",
36-
typ.name(),
37-
FIELD_LEN
38-
))
39-
})?;
40+
if seq.len() < Self::REQUIRED_FIELD_NAMES.len() {
41+
return Err(sequence_length_error(
42+
&typ.name(),
43+
Self::REQUIRED_FIELD_NAMES.len(),
44+
vm,
45+
));
46+
}
4047
Ok(seq)
4148
}
4249

@@ -49,14 +56,14 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
4956
let (body, suffix) = if let Some(_guard) =
5057
rustpython_vm::recursion::ReprGuard::enter(vm, zelf.as_object())
5158
{
52-
if Self::FIELD_NAMES.len() == 1 {
59+
if Self::REQUIRED_FIELD_NAMES.len() == 1 {
5360
let value = zelf.first().unwrap();
54-
let formatted = format_field((value, Self::FIELD_NAMES[0]))?;
61+
let formatted = format_field((value, Self::REQUIRED_FIELD_NAMES[0]))?;
5562
(formatted, ",")
5663
} else {
5764
let fields: PyResult<Vec<_>> = zelf
5865
.iter()
59-
.zip(Self::FIELD_NAMES.iter().copied())
66+
.zip(Self::REQUIRED_FIELD_NAMES.iter().copied())
6067
.map(format_field)
6168
.collect();
6269
(fields?.join(", "), "")
@@ -74,7 +81,7 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
7481

7582
#[extend_class]
7683
fn extend_pyclass(ctx: &Context, class: &'static Py<PyType>) {
77-
for (i, &name) in Self::FIELD_NAMES.iter().enumerate() {
84+
for (i, &name) in Self::REQUIRED_FIELD_NAMES.iter().enumerate() {
7885
// cast i to a u8 so there's less to store in the getter closure.
7986
// Hopefully there's not struct sequences with >=256 elements :P
8087
let i = i as u8;
@@ -90,7 +97,7 @@ pub trait PyStructSequence: StaticType + PyClassImpl + Sized + 'static {
9097
class.set_attr(
9198
identifier!(ctx, __match_args__),
9299
ctx.new_tuple(
93-
Self::FIELD_NAMES
100+
Self::REQUIRED_FIELD_NAMES
94101
.iter()
95102
.map(|&name| ctx.new_str(name).into())
96103
.collect::<Vec<_>>(),

0 commit comments

Comments
 (0)