chore: add todo for waitFor* / browser.disconnected event ordering (microsoft#2520)

mxschmitt · web-flow · commit 475935e67274 · 2024-08-12T14:02:31.000+02:00
diff --git a/playwright/_impl/_browser_type.py b/playwright/_impl/_browser_type.py
@@ -231,6 +231,13 @@ def handle_transport_close(reason: Optional[str]) -> None:
                     context._on_close()
                 browser._on_close()
             connection.cleanup(reason)
+            # TODO: Backport https://github.com/microsoft/playwright/commit/d8d5289e8692c9b1265d23ee66988d1ac5122f33
+            # Give a chance to any API call promises to reject upon page/context closure.
+            # This happens naturally when we receive page.onClose and browser.onClose from the server
+            # in separate tasks. However, upon pipe closure we used to dispatch them all synchronously
+            # here and promises did not have a chance to reject.
+            # The order of rejects vs closure is a part of the API contract and our test runner
+            # relies on it to attribute rejections to the right test.
 
         transport.once("close", handle_transport_close)
 
