Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install php extension with pecl on windows with version. #855

Closed
1 task done
terabytesoftw opened this issue Jul 1, 2024 · 9 comments
Closed
1 task done

Install php extension with pecl on windows with version. #855

terabytesoftw opened this issue Jul 1, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@terabytesoftw
Copy link

terabytesoftw commented Jul 1, 2024

Describe the bug

Install wincache-2.0.0.9

Version

  • v2

Operating systems
Windows

PHP versions
8.1

Screenshots/Logs

Add-Extension: D:\a\_actions\shivammathur\setup-php\main\src\scripts\run.ps1:15
Line |
  15 |  Add-Extension wincache stable 2.0.0.9
     |                                ~~~~~~~
     | Cannot validate argument on parameter 'extension_version'. The argument "2.0.0.9" does not match the
     | "^\d+(\.\d+){0,2}$" pattern. Supply an argument that matches "^\d+(\.\d+){0,2}$" and try the command again.
@terabytesoftw terabytesoftw added the bug Something isn't working label Jul 1, 2024
@shivammathur
Copy link
Owner

I fixed the regex here on setup-php side 594bd59.

@mlocati
Can we have it changed in Install-PhpExtension as well.
And, also changed to search for DLLs in https://downloads.php.net/~windows/pecl/ indexes.

@terabytesoftw
Copy link
Author

terabytesoftw commented Jul 1, 2024

I fixed the regex here on setup-php side 594bd59.

@mlocati Can we have it changed in Install-PhpExtension as well. And, also changed to search for DLLs in https://downloads.php.net/~windows/pecl/ indexes.

Thks, use the branch develop but it doesn't install it.

✗ wincache Could not install wincache on PHP 8.1.29 

@mlocati
Copy link
Contributor

mlocati commented Jul 5, 2024

Can we have it changed in Install-PhpExtension as well.

Done: mlocati/powershell-phpmanager#118

@shivammathur
Copy link
Owner

@mlocati
Thanks for updating the regex.

New extension builds are no longer uploaded to windows.php.net, Would it be possible to change it so that it looks for builds in https://downloads.php.net/~windows/pecl/

@mlocati
Copy link
Contributor

mlocati commented Jul 5, 2024

If I'm not wrong, I should already have done that: see mlocati/powershell-phpmanager#116

@shivammathur
Copy link
Owner

Ah!, I missed that. Thanks again

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Jul 5, 2024
@mlocati
Copy link
Contributor

mlocati commented Jul 5, 2024

Thanks to you!

@shivammathur
Copy link
Owner

Released 2.31.1 with the fix.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Jul 9, 2024
@terabytesoftw
Copy link
Author

Awesome job,

Thks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants