Always truncate deallocated produce message buffers

dpkp · dpkp · commit 4ffd4e94e05e · 2016-03-13T15:08:13.000-07:00
diff --git a/kafka/producer/buffer.py b/kafka/producer/buffer.py
@@ -191,19 +191,12 @@ def deallocate(self, buf):
             buffer_ (io.BytesIO): The buffer to return
         """
         with self._lock:
-            capacity = buf.seek(0, 2)
-
-            # free extra memory if needed
-            if capacity > self._poolable_size:
-                # BytesIO (cpython) only frees memory if 2x reduction or more
-                trunc_to = int(min(capacity / 2, self._poolable_size))
-                buf.truncate(trunc_to)
-
-            buf.seek(0)
-            #buf.write(bytearray(12))
-            #buf.seek(0)
+            # BytesIO.truncate here makes the pool somewhat pointless
+            # but we stick with the BufferPool API until migrating to
+            # bytesarray / memoryview. The buffer we return must not
+            # expose any prior data on read().
+            buf.truncate(0)
             self._free.append(buf)
-
             if self._waiters:
                 self._waiters[0].notify()
 
