Producer.stop() now blocks until async thread completes (drop confusing timeout arg)

Dana Powers · Dana Powers · commit 5682ff63534b · 2015-12-05T04:05:48.000-08:00
diff --git a/kafka/producer/base.py b/kafka/producer/base.py
@@ -415,17 +415,22 @@ def _send_messages(self, topic, partition, *msg, **kwargs):
                 raise
         return resp
 
-    def stop(self, timeout=1):
+    def stop(self):
         """
-        Stop the producer. Optionally wait for the specified timeout before
-        forcefully cleaning up.
+        Stop the producer (async mode). Blocks until async thread completes.
         """
+        if not self.async:
+            log.warning("producer.stop() called, but producer is not async")
+            return
+
+        if self.stopped:
+            log.warning("producer.stop() called, but producer is already stopped")
+            return
+
         if self.async:
             self.queue.put((STOP_ASYNC_PRODUCER, None, None))
-            self.thread.join(timeout)
-
-            if self.thread.is_alive():
-                self.thread_stop_event.set()
+            self.thread_stop_event.set()
+            self.thread.join()
 
         if hasattr(self, '_cleanup_func'):
             # Remove cleanup handler now that we've stopped
