Move Method to Class - final cleanup - TEST FAILS

Siddharta Govindaraj · Siddharta Govindaraj · commit e5f5c7e16c63 · 2015-03-23T12:34:38.000+05:30
diff --git a/stock_alerter/stock.py b/stock_alerter/stock.py
@@ -60,7 +60,7 @@ def _is_crossover_below_to_above(self, prev_ma, prev_reference_ma,
 
     def get_crossover_signal(self, on_date):
         NUM_DAYS = self.LONG_TERM_TIMESPAN + 1
-        closing_price_list = self.history.get_closing_price_list(on_date, NUM_DAYS, self.price_history)
+        closing_price_list = self.history.get_closing_price_list(on_date, NUM_DAYS)
 
         if len(closing_price_list) < NUM_DAYS:
             return StockSignal.neutral
diff --git a/stock_alerter/timeseries.py b/stock_alerter/timeseries.py
@@ -15,11 +15,11 @@ def __getitem__(self, index):
     def update(self, timestamp, value):
         bisect.insort_left(self.series, Update(timestamp, value))
 
-    def get_closing_price_list(self, on_date, num_days, price_history):
+    def get_closing_price_list(self, on_date, num_days):
         closing_price_list = []
         for i in range(num_days):
             chk = on_date.date() - timedelta(i)
-            for price_event in reversed(price_history):
+            for price_event in reversed(self.series):
                 if price_event.timestamp.date() > chk:
                     pass
                 if price_event.timestamp.date() == chk:
