Extract conditional to method

Siddharta Govindaraj · Siddharta Govindaraj · commit e9eff83c63f6 · 2015-03-23T12:17:21.000+05:30
diff --git a/stock_alerter/stock.py b/stock_alerter/stock.py
@@ -49,6 +49,18 @@ def _get_closing_price_list(self, on_date, num_days):
                     break
         return closing_price_list
 
+    def _is_short_term_crossover_below_to_above(self, prev_short_term_ma,
+                                                prev_long_term_ma,
+                                                short_term_ma,
+                                                long_term_ma):
+        return prev_long_term_ma > prev_short_term_ma and long_term_ma < short_term_ma
+
+    def _is_short_term_crossover_above_to_below(self, prev_short_term_ma,
+                                                prev_long_term_ma,
+                                                short_term_ma,
+                                                long_term_ma):
+        return prev_long_term_ma < prev_short_term_ma and long_term_ma > short_term_ma
+
     def get_crossover_signal(self, on_date):
         NUM_DAYS = self.LONG_TERM_TIMESPAN + 1
         closing_price_list = self._get_closing_price_list(on_date, NUM_DAYS)
@@ -70,10 +82,12 @@ def get_crossover_signal(self, on_date):
         prev_short_term_ma = sum([update.price
                                   for update in prev_short_term_series])/self.SHORT_TERM_TIMESPAN
 
-        if prev_long_term_ma > prev_short_term_ma and long_term_ma < short_term_ma:
+        if self._is_short_term_crossover_below_to_above(prev_short_term_ma, prev_long_term_ma,
+                                                        short_term_ma, long_term_ma):
                 return StockSignal.buy
 
-        if prev_long_term_ma < prev_short_term_ma and long_term_ma > short_term_ma:
+        if self._is_short_term_crossover_above_to_below(prev_short_term_ma, prev_long_term_ma,
+                                                        short_term_ma, long_term_ma):
                 return StockSignal.sell
 
         return StockSignal.neutral
