Applied Rename Variable refactoring

Siddharta Govindaraj · Siddharta Govindaraj · commit f7ff299d7d02 · 2015-03-23T11:50:35.000+05:30
diff --git a/stock_alerter/stock.py b/stock_alerter/stock.py
@@ -25,35 +25,35 @@ def is_increasing_trend(self):
             self.price_history[-2].price < self.price_history[-1].price
 
     def get_crossover_signal(self, on_date):
-        cpl = []
+        closing_price_list = []
         for i in range(11):
             chk = on_date.date() - timedelta(i)
             for price_event in reversed(self.price_history):
                 if price_event.timestamp.date() > chk:
                     pass
                 if price_event.timestamp.date() == chk:
-                    cpl.insert(0, price_event)
+                    closing_price_list.insert(0, price_event)
                     break
                 if price_event.timestamp.date() < chk:
-                    cpl.insert(0, price_event)
+                    closing_price_list.insert(0, price_event)
                     break
 
         # Return NEUTRAL signal
-        if len(cpl) < 11:
+        if len(closing_price_list) < 11:
             return 0
 
         # BUY signal
-        if sum([update.price for update in cpl[-11:-1]])/10 \
-                > sum([update.price for update in cpl[-6:-1]])/5 \
-            and sum([update.price for update in cpl[-10:]])/10 \
-                < sum([update.price for update in cpl[-5:]])/5:
+        if sum([update.price for update in closing_price_list[-11:-1]])/10 \
+                > sum([update.price for update in closing_price_list[-6:-1]])/5 \
+            and sum([update.price for update in closing_price_list[-10:]])/10 \
+                < sum([update.price for update in closing_price_list[-5:]])/5:
                     return 1
 
         # BUY signal
-        if sum([update.price for update in cpl[-11:-1]])/10 \
-                < sum([update.price for update in cpl[-6:-1]])/5 \
-            and sum([update.price for update in cpl[-10:]])/10 \
-                > sum([update.price for update in cpl[-5:]])/5:
+        if sum([update.price for update in closing_price_list[-11:-1]])/10 \
+                < sum([update.price for update in closing_price_list[-6:-1]])/5 \
+            and sum([update.price for update in closing_price_list[-10:]])/10 \
+                > sum([update.price for update in closing_price_list[-5:]])/5:
                     return -1
 
         # NEUTRAL signal
