fix: Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito issue (open-feature#1060)

ryanprayogo · toddbaert · web-flow · commit 32340a3e0e11 · 2024-08-22T15:56:19.000-04:00
* fix: Add the net.bytebuddy.experimental=true system property

Workaround to make Mockito tests to pass under Java 21

Signed-off-by: Ryan Prayogo &lt;57620+ryanprayogo@users.noreply.github.com&gt;

* fix: Pin byte-buddy and byte-buddy-agent to a newer version

Signed-off-by: Ryan Prayogo &lt;57620+ryanprayogo@users.noreply.github.com&gt;

* chore: Fix maven warning about deprecated expression

Signed-off-by: Ryan Prayogo &lt;57620+ryanprayogo@users.noreply.github.com&gt;

* chore: Add comments around the Mockito workaround

Signed-off-by: Ryan Prayogo &lt;57620+ryanprayogo@users.noreply.github.com&gt;

* Update pom.xml

Signed-off-by: Todd Baert &lt;todd.baert@dynatrace.com&gt;

---------

Signed-off-by: Ryan Prayogo &lt;57620+ryanprayogo@users.noreply.github.com&gt;
Signed-off-by: Todd Baert &lt;todd.baert@dynatrace.com&gt;
Co-authored-by: Todd Baert &lt;todd.baert@dynatrace.com&gt;
diff --git a/pom.xml b/pom.xml
@@ -13,7 +13,7 @@
     <junit.jupiter.version>5.11.0</junit.jupiter.version>
      <!-- exclusion expression for e2e tests -->
     <testExclusions>**/e2e/*.java</testExclusions>
-    <module-name>${groupId}.${artifactId}</module-name>
+    <module-name>${project.groupId}.${project.artifactId}</module-name>
   </properties>
 
   <name>OpenFeature Java SDK</name>
@@ -151,6 +151,24 @@
   <dependencyManagement>
     <dependencies>
 
+      <!-- Start mockito workaround -->
+      <!-- https://github.com/mockito/mockito/issues/3121 -->
+      <!-- These are transitive dependencies of mockito we are forcing -->
+      <dependency>
+        <groupId>net.bytebuddy</groupId>
+        <artifactId>byte-buddy</artifactId>
+        <version>1.14.19</version>
+        <scope>test</scope>
+      </dependency>
+
+      <dependency>
+        <groupId>net.bytebuddy</groupId>
+        <artifactId>byte-buddy-agent</artifactId>
+        <version>1.14.19</version>
+        <scope>test</scope>
+      </dependency>
+      <!-- End mockito workaround-->
+
       <dependency>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-bom</artifactId>
