Add method to get double

thomaspoignant · rgrassian-split · commit cfc94c5b7733 · 2022-08-03T10:56:42.000-07:00
Signed-off-by: Thomas Poignant &lt;thomas.poignant@gofeatureflag.org&gt;
Signed-off-by: Robert Grassian &lt;robert.grassian@split.io&gt;
diff --git a/src/main/java/dev/openfeature/javasdk/FeatureProvider.java b/src/main/java/dev/openfeature/javasdk/FeatureProvider.java
@@ -8,5 +8,6 @@ public interface FeatureProvider {
     ProviderEvaluation<Boolean> getBooleanEvaluation(String key, Boolean defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);
     ProviderEvaluation<String> getStringEvaluation(String key, String defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);
     ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);
+    ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);
     <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options);
 }
diff --git a/src/main/java/dev/openfeature/javasdk/NoOpProvider.java b/src/main/java/dev/openfeature/javasdk/NoOpProvider.java
@@ -46,7 +46,14 @@ public ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defa
                 .reason(Reason.DEFAULT)
                 .build();
     }
-
+    @Override
+    public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
+        return ProviderEvaluation.<Double>builder()
+                .value(defaultValue)
+                .variant(PASSED_IN_DEFAULT)
+                .reason(Reason.DEFAULT)
+                .build();
+    }
     @Override
     public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
         return ProviderEvaluation.<T>builder()
diff --git a/src/test/java/dev/openfeature/javasdk/AlwaysBrokenProvider.java b/src/test/java/dev/openfeature/javasdk/AlwaysBrokenProvider.java
@@ -27,6 +27,11 @@ public ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defa
         throw new NotImplementedException("BORK");
     }
 
+    @Override
+    public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
+        throw new NotImplementedException("BORK");
+    }
+
     @Override
     public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
         throw new NotImplementedException("BORK");
diff --git a/src/test/java/dev/openfeature/javasdk/DoSomethingProvider.java b/src/test/java/dev/openfeature/javasdk/DoSomethingProvider.java
@@ -27,6 +27,13 @@ public ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defa
                 .build();
     }
 
+    @Override
+    public ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx, FlagEvaluationOptions options) {
+        return ProviderEvaluation.<Double>builder()
+                .value(defaultValue * 100)
+                .build();
+    }
+
     @Override
     public <T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options) {
         return ProviderEvaluation.<T>builder()
diff --git a/src/test/java/dev/openfeature/javasdk/NoOpProviderTest.java b/src/test/java/dev/openfeature/javasdk/NoOpProviderTest.java
@@ -24,6 +24,12 @@ public class NoOpProviderTest {
         assertEquals(4, eval.getValue());
     }
 
+    @Test void noOpdouble() {
+        NoOpProvider p = new NoOpProvider();
+        ProviderEvaluation<Double> eval = p.getDoubleEvaluation("key", 0.4, null, null);
+        assertEquals(0.4, eval.getValue());
+    }
+
     @Test void structure() {
         NoOpProvider p = new NoOpProvider();
         Node<Integer> node = new Node<Integer>();
diff --git a/src/test/java/dev/openfeature/javasdk/ProviderSpecTest.java b/src/test/java/dev/openfeature/javasdk/ProviderSpecTest.java
@@ -27,6 +27,9 @@ public class ProviderSpecTest {
         ProviderEvaluation<Integer> int_result = p.getIntegerEvaluation("key", 4, new EvaluationContext(), FlagEvaluationOptions.builder().build());
         assertNotNull(int_result.getValue());
 
+        ProviderEvaluation<Double> double_result = p.getDoubleEvaluation("key", 0.4, new EvaluationContext(), FlagEvaluationOptions.builder().build());
+        assertNotNull(double_result.getValue());
+
         ProviderEvaluation<String> string_result = p.getStringEvaluation("key", "works", new EvaluationContext(), FlagEvaluationOptions.builder().build());
         assertNotNull(string_result.getValue());
 
@@ -67,6 +70,9 @@ public class ProviderSpecTest {
         ProviderEvaluation<Integer> int_result = p.getIntegerEvaluation("key", 4, new EvaluationContext(), FlagEvaluationOptions.builder().build());
         assertNotNull(int_result.getReason());
 
+        ProviderEvaluation<Double> double_result = p.getDoubleEvaluation("key", 0.4, new EvaluationContext(), FlagEvaluationOptions.builder().build());
+        assertNotNull(double_result.getReason());
+
         ProviderEvaluation<String> string_result = p.getStringEvaluation("key", "works", new EvaluationContext(), FlagEvaluationOptions.builder().build());
         assertNotNull(string_result.getReason());
 

Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,6 @@ public interface FeatureProvider {`
`8`	`8`	`ProviderEvaluation<Boolean> getBooleanEvaluation(String key, Boolean defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);`
`9`	`9`	`ProviderEvaluation<String> getStringEvaluation(String key, String defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);`
`10`	`10`	`ProviderEvaluation<Integer> getIntegerEvaluation(String key, Integer defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);`
	`11`	`+ ProviderEvaluation<Double> getDoubleEvaluation(String key, Double defaultValue, EvaluationContext ctx, FlagEvaluationOptions options);`
`11`	`12`	`<T> ProviderEvaluation<T> getObjectEvaluation(String key, T defaultValue, EvaluationContext invocationContext, FlagEvaluationOptions options);`
`12`	`13`	`}`