error in before results in default params

justinabrahms · justinabrahms · commit d71bf0851c1a · 2022-08-05T14:38:47.000-07:00
diff --git a/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java b/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java
@@ -39,8 +39,6 @@ private <T> FlagEvaluationDetails<T> evaluateFlag(FlagValueType type, String key
         }
 
         // merge of: API.context, client.context, invocation.context
-
-        // TODO: Context transformation?
         HookContext<T> hookCtx = HookContext.from(key, type, this.getMetadata(), openfeatureApi.getProvider().getMetadata(), ctx, defaultValue);
 
         List<Hook> mergedHooks = ObjectUtils.merge(provider.getProviderHooks(), flagOptions.getHooks(), clientHooks, openfeatureApi.getApiHooks());
diff --git a/src/test/java/dev/openfeature/javasdk/HookSpecTest.java b/src/test/java/dev/openfeature/javasdk/HookSpecTest.java
@@ -385,14 +385,16 @@ public void finallyAfter(HookContext<Boolean> ctx, Map<String, Object> hints) {
     }
 
     @Specification(number="4.4.5", text="If an error occurs in the before or after hooks, the error hooks MUST be invoked.")
+    @Specification(number="4.4.7", text="If an error occurs in the before hooks, the default value MUST be returned.")
     @Test void error_hooks__before() {
         Hook hook = mockBooleanHook();
         doThrow(RuntimeException.class).when(hook).before(any(), any());
         Client client = getClient(null);
-        client.getBooleanValue("key", false, new EvaluationContext(),
+        Boolean value = client.getBooleanValue("key", false, new EvaluationContext(),
                 FlagEvaluationOptions.builder().hook(hook).build());
         verify(hook, times(1)).before(any(), any());
         verify(hook, times(1)).error(any(), any(), any());
+        assertEquals(false, value, "Falls through to the default.");
     }
 
     @Specification(number="4.4.5", text="If an error occurs in the before or after hooks, the error hooks MUST be invoked.")

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,6 @@ private <T> FlagEvaluationDetails<T> evaluateFlag(FlagValueType type, String key`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`// merge of: API.context, client.context, invocation.context`
`42`		`-`
`43`		`- // TODO: Context transformation?`
`44`	`42`	`HookContext<T> hookCtx = HookContext.from(key, type, this.getMetadata(), openfeatureApi.getProvider().getMetadata(), ctx, defaultValue);`
`45`	`43`
`46`	`44`	`List<Hook> mergedHooks = ObjectUtils.merge(provider.getProviderHooks(), flagOptions.getHooks(), clientHooks, openfeatureApi.getApiHooks());`