fix: segfault when creating tuple for slicing (denosaurs#37)

DjDeveloperr · web-flow · commit 9a66b878f1c0 · 2023-07-03T10:10:32.000+02:00
* fix: segfault when creating tuple for slicing

* windows ci

* x
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -39,11 +39,11 @@ jobs:
         with:
           deno-version: v1.x
 
-      - name: Setup Python 3.10 (Windows)
+      - name: Setup Python (Windows)
         uses: actions/setup-python@v2
         if: ${{ matrix.os == 'windows-latest' }}
         with:
-          python-version: '3.10'
+          python-version: '3.11'
 
       - name: Install NumPy
         run: python3 -m pip install numpy
diff --git a/src/python.ts b/src/python.ts
@@ -957,26 +957,8 @@ function isSlice(value: unknown): boolean {
  */
 function toSlice(sliceList: string): PyObject {
   if (sliceList.includes(",")) {
-    const pySlicesHandle = sliceList.split(",")
-      .map(toSlice)
-      .map((pyObject) => pyObject.handle);
-
-    const pyTuple_Pack = new Deno.UnsafeFnPointer(
-      // TODO: this isn't really a `bigint`, but Deno's type definitions
-      // haven't been updated to support `number` yet
-      py.PyTuple_Pack!,
-      {
-        parameters: ["i32", ...pySlicesHandle.map(() => "pointer" as const)],
-        result: "pointer",
-      } as const,
-    );
-
-    // SAFETY: idk how to make TS understand this sort of function
-    const pyTupleHandle = (pyTuple_Pack as any).call(
-      pySlicesHandle.length,
-      ...pySlicesHandle,
-    );
-    return new PyObject(pyTupleHandle);
+    const pySlicesHandle = sliceList.split(",").map(toSlice);
+    return python.tuple(pySlicesHandle)[ProxiedPyObject];
   } else if (/^\s*-?\d+\s*$/.test(sliceList)) {
     return PyObject.from(parseInt(sliceList));
   } else if (/^\s*\.\.\.\s*$/.test(sliceList)) {
