Feel free to create a PR

I had considered doing so, but didn't have the time to understand your
testing framework.

On 23 June 2014 22:05, Ian Cordasco notifications@github.com wrote:

Feel free to create a PR

—
Reply to this email directly or view it on GitHub
#259 (comment)
.

The tests and the docs are separate entities. They do not affect each other. Simply fixing the docs does not require understanding of the tests.

Sure, but the tests are not sufficient. Fine. I'll fix only the docs.

On 24 June 2014 09:15, Ian Cordasco notifications@github.com wrote:

The tests and the docs are separate entities. They do not affect each
other. Simply fixing the docs does not require understanding of the tests.

—
Reply to this email directly or view it on GitHub
#259 (comment)
.

It would also be nice to make base optional (default='master') but that
requires a parameter reordering.

On 24 June 2014 09:32, Joel Nothman jnothman@student.usyd.edu.au wrote:

Sure, but the tests are not sufficient. Fine. I'll fix only the docs.

On 24 June 2014 09:15, Ian Cordasco notifications@github.com wrote:

The tests and the docs are separate entities. They do not affect each
other. Simply fixing the docs does not require understanding of the tests.

—
Reply to this email directly or view it on GitHub
#259 (comment)
.

For future readers who find this and realize I never responded to @jnothman's last idea, here's the problem: while most repositories use master as their default branch, there are more than enough that don't to justify this. A good recipe (that should be documented) is r.create_pull_request(title='..', body='...', base=r.default_branch, head='user:branch').

But you could still make base optional to facilitate that case...?

So I try to mirror the GitHub API. If something is required by the API, I require it be provided by the user. That said, I could allow the user to pass None and in that case use self.default_branch. I just don't know how I like that. @esacteksab thoughts?

I agree. Github requires it, we should enforce that requirement.