Define a 'prelude' module for common imports #347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e58e46f to
8e11906
Compare
fe153b6 to
3343536
Compare
|
I decided to include both Note that explicit imports always override bulk imports, so that the following code is unambiguous: use self::conflicting::Serde;
use slog::prelude::*;
mod conflicting {
pub struct Serde(pub i32);
}
fn main() {
let x = Serde(3);
let x: conflicting::Serde = x;
}I have added a test for this to ensure this is always the case. |
3343536 to
18120d6
Compare
The FnValue/Serde types are included.
18120d6 to
a31da4a
Compare
dpc
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make imports more convenient.
TODO: Decide if the following items should be included:
slog::FnValueslog::Serdeslog::PushFnValueEDIT: I conservatively decided against including these items.EDIT 2: I decided to include the first two