Skip to content

Commit 07e3010

Browse files
author
Sascha Schumann
committed
get rid of --with-shared-apache
it's currently broken and redundant (use APXS instead)
1 parent bf8c6db commit 07e3010

File tree

3 files changed

+12
-63
lines changed

3 files changed

+12
-63
lines changed

acinclude.m4

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@ AC_DEFUN(AC_ADD_LIBPATH,[
3838
AC_EXPAND_PATH($1, ai_p)
3939
AC_PHP_ONCE(LIBPATH, $ai_p, [
4040
EXTRA_LIBS="$EXTRA_LIBS -L$ai_p"
41-
if test -n "$rpath_raw" ; then
42-
RPATHS="$RPATHS ${raw_runpath_switch}$ai_p"
43-
elif test -n "$APXS" ; then
41+
RAW_RPATHS="$RAW_RPATHS ${raw_runpath_switch}$ai_p"
42+
if test -n "$APXS" ; then
4443
RPATHS="$RPATHS ${apxs_runpath_switch}$ai_p'"
4544
else
4645
RPATHS="$RPATHS ${ld_runpath_switch}$ai_p"

configure.in.in

Lines changed: 8 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,13 @@ for arg in $@; do
1616
esac
1717
done
1818

19+
if test "$with_shared_apache" != "no" ; then
20+
echo ""
21+
echo "ERROR: --with-shared-apache is not supported."
22+
echo " Please read INSTALL.DSO for instructions on using APXS."
23+
exit 1
24+
fi
25+
1926
if test "$recurse" = "yes"; then
2027
cwd=`pwd`
2128
(set -x; test -d libzend || mkdir libzend ; cd libzend; $cwd/$srcdir/libzend/configure --cache-file=$cwd/config.cache $@)
@@ -365,64 +372,6 @@ AC_ARG_WITH(apxs,
365372
366373
APACHE_INSTALL_FILES="$srcdir/mod_php4.* libphp4.module"
367374
368-
AC_MSG_CHECKING(for Apache module support via DSO through APACI)
369-
AC_ARG_WITH(shared-apache,
370-
[ --with-shared-apache[=DIR] Build shared Apache module. DIR is the top-level
371-
Apache build directory, defaults to /usr/local/etc/httpd.
372-
(This option needs Perl installed)],
373-
[
374-
if test "$withval" = "yes"; then
375-
# Apache's default directory
376-
withval=/usr/local/etc/httpd
377-
fi
378-
if test "$withval" != "no"; then
379-
rpath_raw=yes
380-
if test -f $withval/src/include/httpd.h; then
381-
AC_EXPAND_PATH($withval, withval)
382-
APACHE_INCLUDE="-I$withval/src/include -I$withval/src/os/unix"
383-
APACHE_TARGET=$withval/src/modules/php4
384-
if test ! -d $APACHE_TARGET; then
385-
mkdir $APACHE_TARGET
386-
fi
387-
CFLAGS_SHLIB=`perl -V:cccdlflags | cut -d\' -f2`
388-
LDFLAGS_SHLIB=`perl -V:lddlflags | cut -d\' -f2`
389-
LDFLAGS_SHLIB_EXPORT=`perl -V:ccdlflags | cut -d\' -f2`
390-
PHP_LIBS=
391-
BINNAME=libmodphp4-so.a
392-
INSTALL_IT="mkdir -p $APACHE_TARGET; cp $BINNAME $APACHE_INSTALL_FILES $APACHE_TARGET; cp apMakefile.tmpl $APACHE_TARGET/Makefile.tmpl; cp apMakefile.libdir $APACHE_TARGET/Makefile.libdir"
393-
AC_DEFINE(APACHE)
394-
AC_MSG_RESULT(yes - Shared Apache 1.3.x)
395-
STRONGHOLD=
396-
if test -f $withval/src/include/ap_config.h; then
397-
AC_DEFINE(HAVE_AP_CONFIG_H)
398-
fi
399-
if test -f $withval/src/include/ap_compat.h; then
400-
AC_DEFINE(HAVE_AP_COMPAT_H)
401-
if test ! -f $withval/src/include/ap_config_auto.h; then
402-
AC_MSG_ERROR(Please run Apache's configure or src/Configure program once and try again)
403-
fi
404-
else
405-
if test -f $withval/src/include/compat.h; then
406-
AC_DEFINE(HAVE_OLD_COMPAT_H)
407-
fi
408-
fi
409-
else
410-
AC_MSG_RESULT(no)
411-
AC_MSG_ERROR(Invalid Apache directory - unable to find httpd.h under $withval/src/include)
412-
fi
413-
fi
414-
INCLUDES="$INCLUDES $APACHE_INCLUDE"
415-
AC_SUBST(APACHE_INCLUDE)
416-
AC_SUBST(APACHE_TARGET)
417-
AC_SUBST(INSTALL_IT)
418-
AC_SUBST(BINNAME)
419-
AC_SUBST(PHP_LIBS)
420-
],[
421-
AC_MSG_RESULT(no)
422-
])
423-
424-
425-
426375
if test "$BINNAME" != "libmodphp4-so.a"; then
427376
if test "$BINNAME" != "libphp4.so"; then
428377
AC_MSG_CHECKING(for Apache module support)
@@ -916,6 +865,7 @@ AC_SUBST(CFLAGS_SHLIB)
916865
AC_SUBST(LDFLAGS_SHLIB)
917866
AC_SUBST(LDFLAGS_SHLIB_EXPORT)
918867
AC_SUBST(RPATHS)
868+
AC_SUBST(RAW_RPATHS)
919869
920870
PHP_BUILD_DATE=`date '+%Y-%m-%d'`
921871
AC_SUBST(PHP_BUILD_DATE)

libphp4.module.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Name: php4_module
22
ConfigStart
33
RULE_WANTHSREGEX=@HSREGEX@
4-
LDFLAGS_SHLIB="@RPATHS@ $LDFLAGS_SHLIB"
5-
LIBS="@PHP_LIBS@ @EXTRA_LIBS@ @LIBS@ @RDYNAMIC_LFLAGS@ $LIBS"
4+
LDFLAGS_SHLIB="@RAW_RPATHS@ $LDFLAGS_SHLIB"
5+
LIBS="@RPATHS@ @PHP_LIBS@ @EXTRA_LIBS@ @LIBS@ @RDYNAMIC_LFLAGS@ $LIBS"
66
RULE_HIDE=yes
77
CFLAGS="$CFLAGS -I@abs_srcdir@ -I@abs_srcdir@/libzend -I@abs_builddir@/libzend -I@abs_builddir@"
88
ConfigEnd

0 commit comments

Comments
 (0)