Skip to content

Commit 08546ef

Browse files
author
Thies C. Arntzen
committed
changed to use Z_* macros
1 parent 1be0975 commit 08546ef

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

ext/standard/assert.c

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ PHP_FUNCTION(assert)
154154
zval retval;
155155
int old_error_reporting = 0; /* shut up gcc! */
156156

157-
myeval = (*assertion)->value.str.val;
157+
myeval = Z_STRVAL_PP(assertion);
158158

159159
if (ASSERT(quiet_eval)) {
160160
old_error_reporting = EG(error_reporting);
@@ -174,10 +174,10 @@ PHP_FUNCTION(assert)
174174
}
175175

176176
convert_to_boolean(&retval);
177-
val = retval.value.lval;
177+
val = Z_LVAL(retval);
178178
} else {
179179
convert_to_boolean_ex(assertion);
180-
val = (*assertion)->value.lval;
180+
val = Z_LVAL_PP(assertion);
181181
}
182182

183183
if (val) {
@@ -210,18 +210,17 @@ PHP_FUNCTION(assert)
210210
MAKE_STD_ZVAL(args[4]);
211211
*/
212212

213-
args[0]->type = IS_STRING; args[0]->value.str.val = estrdup(SAFE_STRING(cbfunc)); args[0]->value.str.len = strlen(args[0]->value.str.val);
214-
args[1]->type = IS_STRING; args[1]->value.str.val = estrdup(SAFE_STRING(filename)); args[1]->value.str.len = strlen(args[1]->value.str.val);
215-
args[2]->type = IS_LONG; args[2]->value.lval = lineno;
216-
args[3]->type = IS_STRING; args[3]->value.str.val = estrdup(SAFE_STRING(myeval)); args[3]->value.str.len = strlen(args[3]->value.str.val);
213+
ZVAL_STRING(args[0],SAFE_STRING(cbfunc),1);
214+
ZVAL_STRING(args[1],SAFE_STRING(filename),1);
215+
ZVAL_LONG (args[2],lineno);
216+
ZVAL_STRING(args[3],SAFE_STRING(myeval),1);
217217
/*
218218
this is always "assert" so it's useless
219219
args[4]->type = IS_STRING; args[4]->value.str.val = estrdup(SAFE_STRING(function)); args[4]->value.str.len = strlen(args[4]->value.str.val);
220220
*/
221221

222222
MAKE_STD_ZVAL(retval);
223-
retval->type = IS_BOOL;
224-
retval->value.lval = 0;
223+
ZVAL_BOOL(retval,0);
225224

226225
/* XXX do we want to check for error here? */
227226
call_user_function(CG(function_table), NULL, args[0], retval, 3, args+1);
@@ -268,7 +267,7 @@ PHP_FUNCTION(assert_options)
268267
oldint = ASSERT(active);
269268
if (ac == 2) {
270269
convert_to_long_ex(value);
271-
ASSERT(active) = (*value)->value.lval;
270+
ASSERT(active) = Z_LVAL_PP(value);
272271
}
273272
RETURN_LONG(oldint);
274273
break;
@@ -277,7 +276,7 @@ PHP_FUNCTION(assert_options)
277276
oldint = ASSERT(bail);
278277
if (ac == 2) {
279278
convert_to_long_ex(value);
280-
ASSERT(bail) = (*value)->value.lval;
279+
ASSERT(bail) = Z_LVAL_PP(value);
281280
}
282281
RETURN_LONG(oldint);
283282
break;
@@ -286,7 +285,7 @@ PHP_FUNCTION(assert_options)
286285
oldint = ASSERT(quiet_eval);
287286
if (ac == 2) {
288287
convert_to_long_ex(value);
289-
ASSERT(quiet_eval) = (*value)->value.lval;
288+
ASSERT(quiet_eval) = Z_LVAL_PP(value);
290289
}
291290
RETURN_LONG(oldint);
292291
break;
@@ -295,7 +294,7 @@ PHP_FUNCTION(assert_options)
295294
oldint = ASSERT(warning);
296295
if (ac == 2) {
297296
convert_to_long_ex(value);
298-
ASSERT(warning) = (*value)->value.lval;
297+
ASSERT(warning) = Z_LVAL_PP(value);
299298
}
300299
RETURN_LONG(oldint);
301300
break;
@@ -309,13 +308,13 @@ PHP_FUNCTION(assert_options)
309308
efree(oldstr);
310309
}
311310
convert_to_string_ex(value);
312-
ASSERT(callback) = estrndup((*value)->value.str.val,(*value)->value.str.len);
311+
ASSERT(callback) = estrndup(Z_STRVAL_PP(value), Z_STRLEN_PP(value));
313312
}
314313
return;
315314
break;
316315

317316
default:
318-
php_error(E_WARNING,"Unknown value %d.",(*what)->value.lval);
317+
php_error(E_WARNING,"Unknown value %d.",Z_LVAL_PP(what));
319318
break;
320319
}
321320

0 commit comments

Comments
 (0)