Interrupt loop, if the stream op fails.

Sascha Schumann · Sascha Schumann · commit 1918011c0184 · 2002-10-04T19:36:09.000Z
diff --git a/main/streams.c b/main/streams.c
@@ -713,8 +713,11 @@ PHPAPI char *_php_stream_gets(php_stream *stream, char *buf, size_t maxlen TSRML
 			if (toread > stream->chunk_size)
 				toread = stream->chunk_size;
 
-			/* XXX: Should not the loop end, if the stream op fails? */
 			php_stream_fill_read_buffer(stream, toread TSRMLS_CC);
+
+			if (stream->writepos - stream->readpos == 0) {
+				break;
+			}
 		}
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -713,8 +713,11 @@ PHPAPI char _php_stream_gets(php_stream stream, char *buf, size_t maxlen TSRML`
`713`	`713`	`if (toread > stream->chunk_size)`
`714`	`714`	`toread = stream->chunk_size;`
`715`	`715`
`716`		`- /* XXX: Should not the loop end, if the stream op fails? */`
`717`	`716`	`php_stream_fill_read_buffer(stream, toread TSRMLS_CC);`
	`717`	`+`
	`718`	`+ if (stream->writepos - stream->readpos == 0) {`
	`719`	`+ break;`
	`720`	`+ }`
`718`	`721`	`}`
`719`	`722`	`}`
`720`	`723`