A slightly better content-type check.

Ilia Alshanetsky · Ilia Alshanetsky · commit 29be52fbfb7a · 2002-10-04T21:31:34.000Z
diff --git a/sapi/apache2filter/sapi_apache2.c b/sapi/apache2filter/sapi_apache2.c
@@ -575,7 +575,7 @@ static void php_insert_filter(request_rec *r)
 	int content_type_len = strlen("application/x-httpd-php");
 
 	if (r->content_type && !strncmp(r->content_type, "application/x-httpd-php", content_type_len-1)) {
-		if (r->content_type[content_type_len] == '\0' || !strncmp(r->content_type+content_type_len, "-source", strlen("-source"))) { 
+		if (r->content_type[content_type_len] == '\0' || !strncmp(r->content_type+content_type_len, "-source", sizeof("-source"))) { 
 			php_add_filter(r, r->output_filters);
 			php_add_filter(r, r->input_filters);
 		}	

Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ static void php_insert_filter(request_rec *r)`
`575`	`575`	`int content_type_len = strlen("application/x-httpd-php");`
`576`	`576`
`577`	`577`	`if (r->content_type && !strncmp(r->content_type, "application/x-httpd-php", content_type_len-1)) {`
`578`		`- if (r->content_type[content_type_len] == '\0' \|\| !strncmp(r->content_type+content_type_len, "-source", strlen("-source"))) {`
	`578`	`+ if (r->content_type[content_type_len] == '\0' \|\| !strncmp(r->content_type+content_type_len, "-source", sizeof("-source"))) {`
`579`	`579`	`php_add_filter(r, r->output_filters);`
`580`	`580`	`php_add_filter(r, r->input_filters);`
`581`	`581`	`}`