ecalloc doesn't return NULL

helly25 · helly25 · commit 4eb6392519c0 · 2003-06-14T11:32:30.000Z
diff --git a/Zend/zend_hash.c b/Zend/zend_hash.c
@@ -146,14 +146,13 @@ ZEND_API int _zend_hash_init(HashTable *ht, uint nSize, hash_func_t pHashFunctio
 	/* Uses ecalloc() so that Bucket* == NULL */
 	if (persistent) {
 		ht->arBuckets = (Bucket **) calloc(ht->nTableSize, sizeof(Bucket *));
+		if (!ht->arBuckets) {
+			return FAILURE;
+		}
 	} else {
 		ht->arBuckets = (Bucket **) ecalloc_rel(ht->nTableSize, sizeof(Bucket *));
 	}
 	
-	if (!ht->arBuckets) {
-		return FAILURE;
-	}
-
 	ht->pDestructor = pDestructor;
 	ht->pListHead = NULL;
 	ht->pListTail = NULL;
