Add a few notes

Sascha Schumann · Sascha Schumann · commit a4ec211e9e01 · 2002-10-04T19:08:43.000Z
diff --git a/main/network.c b/main/network.c
@@ -800,6 +800,7 @@ DUMP_SOCK_STATE("check for EOF", sock);
 	}
 
 #if HAVE_OPENSSL_EXT
+	/* XXX: Where is the complex OpenSSL error handling? */
 	if (sock->ssl_active)
 		nr_bytes = SSL_read(sock->ssl_handle, buf, count);
 	else
diff --git a/main/streams.c b/main/streams.c
@@ -708,11 +708,10 @@ PHPAPI char *_php_stream_gets(php_stream *stream, char *buf, size_t maxlen TSRML
 				break;
 			}
 		} else {
+			/* XXX: Should be fine to always read chunk_size */
 			size_t toread = maxlen - 1;
 			if (toread > stream->chunk_size)
 				toread = stream->chunk_size;
-			else if (toread < stream->chunk_size)
-				stream->chunk_size = toread;
 
 			/* XXX: Should not the loop end, if the stream op fails? */
 			php_stream_fill_read_buffer(stream, toread TSRMLS_CC);

Original file line number	Diff line number	Diff line change
`@@ -800,6 +800,7 @@ DUMP_SOCK_STATE("check for EOF", sock);`
`800`	`800`	`}`
`801`	`801`
`802`	`802`	`#if HAVE_OPENSSL_EXT`
	`803`	`+ /* XXX: Where is the complex OpenSSL error handling? */`
`803`	`804`	`if (sock->ssl_active)`
`804`	`805`	`nr_bytes = SSL_read(sock->ssl_handle, buf, count);`
`805`	`806`	`else`