- one more place which seems to have needed fixing. I don't have time to look

Andi Gutmans · Andi Gutmans · commit b32b2831d8d9 · 1999-04-15T17:43:16.000Z
more into it. I hope we don't have anymore places which need fixing.
diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
@@ -1417,8 +1417,8 @@ binary_assign_op_addr: {
 			case ZEND_SEND_VAR:
 				if (function_being_called
 					&& function_being_called->common.arg_types
-					&& opline->op2.u.opline_num<function_being_called->common.arg_types[0]
-					&& function_being_called->common.arg_types[1+opline->op2.u.opline_num]==BYREF_FORCE) {
+					&& opline->op2.u.opline_num<=function_being_called->common.arg_types[0]
+					&& function_being_called->common.arg_types[opline->op2.u.opline_num]==BYREF_FORCE) {
 						goto send_by_ref;
 				}
 				{

Original file line number	Diff line number	Diff line change
`@@ -1417,8 +1417,8 @@ binary_assign_op_addr: {`
`1417`	`1417`	`case ZEND_SEND_VAR:`
`1418`	`1418`	`if (function_being_called`
`1419`	`1419`	`&& function_being_called->common.arg_types`
`1420`		`- && opline->op2.u.opline_num<function_being_called->common.arg_types[0]`
`1421`		`- && function_being_called->common.arg_types[1+opline->op2.u.opline_num]==BYREF_FORCE) {`
	`1420`	`+ && opline->op2.u.opline_num<=function_being_called->common.arg_types[0]`
	`1421`	`+ && function_being_called->common.arg_types[opline->op2.u.opline_num]==BYREF_FORCE) {`
`1422`	`1422`	`goto send_by_ref;`
`1423`	`1423`	`}`
`1424`	`1424`	`{`