- Fixed a segfault when reading from an HTTP stream.

Derick Rethans · Derick Rethans · commit badfa1304d60 · 2007-11-29T12:27:49.000Z
diff --git a/ext/standard/http_fopen_wrapper.c b/ext/standard/http_fopen_wrapper.c
@@ -545,7 +545,7 @@ php_stream *php_stream_url_wrap_http_ex(php_stream_wrapper *wrapper, char *path,
 			}
 			/* when we request only the header, don't fail even on error codes */
 			if ((options & STREAM_ONLY_GET_HEADERS) ||
-				(php_stream_context_get_option(context, "http", "ignore_errors",  &tmpzval) == SUCCESS && zend_is_true(*tmpzval)) ) {
+				(context && php_stream_context_get_option(context, "http", "ignore_errors",  &tmpzval) == SUCCESS && zend_is_true(*tmpzval)) ) {
 				reqok = 1;
 			}
 			switch(response_code) {
diff --git a/ext/standard/tests/network/http-stream.phpt b/ext/standard/tests/network/http-stream.phpt
@@ -0,0 +1,10 @@
+--TEST--
+http-stream test
+--FILE--
+<?php
+$d = new DomDocument;
+$e = $d->load("http://php.net/news.rss");
+echo "ALIVE\n";
+?>
+--EXPECTF--
+ALIVE

Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,7 @@ php_stream php_stream_url_wrap_http_ex(php_stream_wrapper wrapper, char *path,`
`545`	`545`	`}`
`546`	`546`	`/* when we request only the header, don't fail even on error codes */`
`547`	`547`	`if ((options & STREAM_ONLY_GET_HEADERS) \|\|`
`548`		`- (php_stream_context_get_option(context, "http", "ignore_errors", &tmpzval) == SUCCESS && zend_is_true(*tmpzval)) ) {`
	`548`	`+ (context && php_stream_context_get_option(context, "http", "ignore_errors", &tmpzval) == SUCCESS && zend_is_true(*tmpzval)) ) {`
`549`	`549`	`reqok = 1;`
`550`	`550`	`}`
`551`	`551`	`switch(response_code) {`