Ilia Alshanetsky · Ilia Alshanetsky · commit c81c24d90593 · 2007-12-02T20:59:09.000Z
MFB: Fixed bug #43457 (Prepared statement with incorrect parms doens't
throw exception with pdo_pgsql driver)
diff --git a/ext/pdo_pgsql/pgsql_statement.c b/ext/pdo_pgsql/pgsql_statement.c
@@ -175,7 +175,7 @@ static int pgsql_stmt_param_hook(pdo_stmt_t *stmt, struct pdo_bound_param_data *
 								param->name, param->namelen + 1, (void**)&nameptr)) {
 							param->paramno = atoi(nameptr + 1) - 1;
 						} else {
-							pdo_pgsql_error_stmt(stmt, PGRES_FATAL_ERROR, "HY093");
+							pdo_raise_impl_error(stmt->dbh, stmt, "HY093", param->name TSRMLS_CC);
 							return 0;
 						}
 					}
diff --git a/ext/pdo_pgsql/tests/bug36727.phpt b/ext/pdo_pgsql/tests/bug36727.phpt
@@ -19,5 +19,6 @@ var_dump($stmt->bindValue(':test', 1, PDO::PARAM_INT));
 echo "Done\n";
 ?>
 --EXPECT--
+Warning: PDOStatement::bindValue(): SQLSTATE[HY093]: Invalid parameter number: :test in %s/bug36727.php on line %d
 bool(false)
-Done
+Done

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ static int pgsql_stmt_param_hook(pdo_stmt_t stmt, struct pdo_bound_param_data `
`175`	`175`	`param->name, param->namelen + 1, (void**)&nameptr)) {`
`176`	`176`	`param->paramno = atoi(nameptr + 1) - 1;`
`177`	`177`	`} else {`
`178`		`- pdo_pgsql_error_stmt(stmt, PGRES_FATAL_ERROR, "HY093");`
	`178`	`+ pdo_raise_impl_error(stmt->dbh, stmt, "HY093", param->name TSRMLS_CC);`
`179`	`179`	`return 0;`
`180`	`180`	`}`
`181`	`181`	`}`