Fix a maintainer-mode warning

rlerdorf · rlerdorf · commit ca362445c486 · 1999-12-05T13:41:42.000Z
diff --git a/ext/standard/lcg.c b/ext/standard/lcg.c
@@ -59,7 +59,9 @@ double php_combined_lcg(void)
 	return z * 4.656613e-10;
 }
 
-static void init_globals(LCGLS_D)
+static void lcg_init_globals(LCGLS_D);
+
+static void lcg_init_globals(LCGLS_D)
 {
 	LCG(s1) = 1;
 #ifdef ZTS
@@ -72,9 +74,9 @@ static void init_globals(LCGLS_D)
 static int php_minit_lcg(INIT_FUNC_ARGS)
 {
 #ifdef ZTS
-	lcg_globals_id = ts_allocate_id(sizeof(php_lcg_globals), init_globals, NULL);
+	lcg_globals_id = ts_allocate_id(sizeof(php_lcg_globals), lcg_init_globals, NULL);
 #else
-	init_globals();
+	lcg_init_globals();
 #endif
 	return SUCCESS;
 }
diff --git a/ext/standard/php_lcg.h b/ext/standard/php_lcg.h
@@ -32,7 +32,7 @@ PHP_FUNCTION(lcg_value);
 #define LCG(v) (lcg_globals->v)
 #define LCGLS_FETCH() php_lcg_globals *lcg_globals = ts_resource(lcg_globals_id)
 #else
-#define LCGLS_D
+#define LCGLS_D void
 #define LCG(v) (lcg_globals.v)
 #define LCGLS_FETCH()
 #endif

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ double php_combined_lcg(void)`
`59`	`59`	`return z * 4.656613e-10;`
`60`	`60`	`}`
`61`	`61`
`62`		`-static void init_globals(LCGLS_D)`
	`62`	`+static void lcg_init_globals(LCGLS_D);`
	`63`	`+`
	`64`	`+static void lcg_init_globals(LCGLS_D)`
`63`	`65`	`{`
`64`	`66`	`LCG(s1) = 1;`
`65`	`67`	`#ifdef ZTS`
`@@ -72,9 +74,9 @@ static void init_globals(LCGLS_D)`
`72`	`74`	`static int php_minit_lcg(INIT_FUNC_ARGS)`
`73`	`75`	`{`
`74`	`76`	`#ifdef ZTS`
`75`		`- lcg_globals_id = ts_allocate_id(sizeof(php_lcg_globals), init_globals, NULL);`
	`77`	`+ lcg_globals_id = ts_allocate_id(sizeof(php_lcg_globals), lcg_init_globals, NULL);`
`76`	`78`	`#else`
`77`		`- init_globals();`
	`79`	`+ lcg_init_globals();`
`78`	`80`	`#endif`
`79`	`81`	`return SUCCESS;`
`80`	`82`	`}`