This shouldn't be refcount = 0, causes a memory overrun

Sterling Hughes · Sterling Hughes · commit cc0c4e4981e6 · 2003-06-14T04:02:12.000Z
diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c
@@ -97,11 +97,10 @@ static zval *
 sxe_property_read(zval *object, zval *member TSRMLS_DC)
 {
 	zval           *return_value;
-	zval           *value;
+	zval           *value = NULL;
 	php_sxe_object *sxe;
 	char           *name;
 	char           *contents;
-	char           *mapname = NULL;
 	xmlNodePtr      node;
 	xmlAttrPtr      attr;
 	int             counter = 0;
@@ -122,7 +121,6 @@ sxe_property_read(zval *object, zval *member TSRMLS_DC)
 			APPEND_PREV_ELEMENT(counter, value);
 			
 			MAKE_STD_ZVAL(value);
-			value->refcount = 0;
 			contents = xmlNodeListGetString((xmlDocPtr) sxe->document->ptr, attr->children, 1);
 			ZVAL_STRING(value, contents, 0);
 			APPEND_CUR_ELEMENT(counter, value);
