Skip to content

Commit d1d7432

Browse files
committed
addes more logging and security options
1 parent 0fe40d5 commit d1d7432

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pear/PEAR/Packager.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,10 @@ function package($pkgfile = "package.xml")
174174
fclose($fp);
175175
chdir(dirname($this->tmpdir));
176176
// XXX FIXME Windows and non-GNU tar
177-
$pkgver = quotemeta($this->pkgver);
178-
system("tar -cvzf $pwd/${pkgver}.tgz $pkgver");
177+
$pkgver = $this->pkgver;
178+
$cmd = "tar -cvzf $pwd/${pkgver}.tgz $pkgver";
179+
$this->log(1, `$cmd`);
180+
$this->log(1, "Package $pwd/${pkgver}.tgz done");
179181
}
180182

181183
// }}}
@@ -237,6 +239,8 @@ function startHandler($xp, $name, $attribs)
237239
$pwd = getcwd();
238240
$this->pkgver = $this->pkginfo["Package,Name"] . "-" .
239241
$this->pkginfo["Release,Version"];
242+
// don't want extrange characters
243+
$this->pkgver = ereg_replace ("[^a-zA-Z0-9._-]", '_', $this->pkgver);
240244
$this->tmpdir = $pwd . DIRECTORY_SEPARATOR . $this->pkgver;
241245
if (file_exists($this->tmpdir)) {
242246
xml_parser_free($xp);

0 commit comments

Comments
 (0)